Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of the Textarea field #33

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Sep 8, 2020

Changes

Steps to reproduce

  1. Create a new block with a Textarea field
  2. Publish it
  3. Add it to the block editor
  4. Expected: there's no notice
  5. Actual: this notice shows for about a second, then disappears:

notice-here

Testing instructions for this PR

  1. Create a new block with 3 Textarea fields
  2. For the first Textarea, set New Lines > Automatically add paragraphs
  3. For the second, set New Lines > Automatically add linebreaks
  4. For the third, set New Lines > No formatting
  5. Publish it
  6. Add it to the block editor
  7. Expected: there's no PHP notice anymore
  8. Expected: the linebreak and newline behavior is the same as before

@kienstra
Copy link
Contributor Author

kienstra commented Sep 8, 2020

Hi @lukecarbis,
Could you please review this? Thanks!

@kienstra kienstra requested a review from lukecarbis September 8, 2020 18:29
Copy link
Contributor

@mindctrl mindctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@nickcernis nickcernis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no “"type" schema keyword for can only be one of the built-in types” message for a new custom block with textarea fields.

@kienstra
Copy link
Contributor Author

kienstra commented Sep 9, 2020

Thanks!

@kienstra kienstra merged commit 5636c1e into develop Sep 9, 2020
@kienstra kienstra deleted the update/textarea-type branch September 9, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants