[LOC-6168] Fetch plugin updates from WPE servers #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcernis
force-pushed
the
nc/LOC-6168
branch
3 times, most recently
from
563f5d7 to
1db0ba6
Compare
Adapted from the sample code at https://github.com/wpengine/plugin-updater.
This plugin can no longer be published on WP.org due to blocked access.
To work with latest WP develop. - Increase timeout from 100s to 300s. Needed when running locally. - Use custom insert block method. The current insertBlock method fails in Circle but we can't upgrade to the latest e2e-test-utils without also upgrading Node.js, which has cascading side-effects in terms of dependencies. - Serve a fake favicon to prevent test failures due to 404s thrown in the console that make Jest think the test has failed.
This test is intended to check that the editor page still loads if the user creates a custom field with no fields. The test passes locally but fails in Circle. Rather than continuing to tweak it to attempt to appease Circle I opted to delete it. It seems to have limited value since (a) it passes right now and (b) it doesn't seem common that a user will add a custom field with no fields.
nickcernis
force-pushed
the
nc/LOC-6168
branch
from
5c93a55 to
167660c
Compare
bgturner
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no changelog in this PR because these are written on the GitHub releases page (this repo is public).
I did not add an
npm run zipscript to this PR like I have for other PRs. Doing so required upgrading the current version of Node.js, which introduces complexity due to archived dependencies (material-ui/core, react-autosize-textarea) not supporting Node 18 without more involved upgrade/migration paths. For now we can grab the zip from Circle.To test
wp plugin install --activate transients-managerupdate_pluginstransient you may have that could result in updates coming from WP.org instead of WPE if a plugin update check occurred after you installed but before you activated Genesis Blocks. This is just to accelerate testing (it prevents you having to wait for transients to expire). Customers will not have to do this once upgrading to 1.7.1 of the plugin.At this point the Genesis Custom Blocks on your site is the old version without WPE update checking (that is just what's uploaded to the WPE update server at the moment — we will change that when this PR is merged). You will need to delete the plugin and reinstall the one linked above if you want to do further tests.