Make GCB compatible with 6.5
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
commented
Mar 12, 2024
| * @param {Object} post Post object. | ||
| */ | ||
| const setupEditor = ( post ) => { | ||
| setupEditorState( post ); |
There was a problem hiding this comment.
This file is a big wrapper for setupEditorState.
It's not needed anymore.
How to test GCB for the next WP versionIf you're wondering how we test this plugin for WP releases… We just bump the version in the PHPUnit tests and e2e tests. For example, with WP diff --git a/.circleci/config.yml b/.circleci/config.yml
index 6faa3d89..02eb5165 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -86,7 +86,7 @@ jobs:
- run:
name: Installing WordPress and setting up tests
command: |
- git clone git://develop.git.wordpress.org/ wordpress-develop
+ git clone -b 6.5 git://develop.git.wordpress.org/ wordpress-develop
cp wordpress-develop/wp-tests-config-sample.php wordpress-develop/wp-tests-config.php
sed -i 's/localhost/127.0.0.1/g' wordpress-develop/wp-tests-config.php
sed -i 's/yourpasswordhere/<insert password here>/g' wordpress-develop/wp-tests-config.php
diff --git a/.wp-env.json b/.wp-env.json
index b00b8969..04e74fa4 100644
--- a/.wp-env.json
+++ b/.wp-env.json
@@ -1,5 +1,5 @@
{
- "core": null,
+ "core": "WordPress/WordPress#6.5-branch",
"plugins": [ ".", "./tests/e2e/plugins/testing-blocks" ],
"phpVersion": "8.3"
}
…then we see if the tests pass. Then, we'll revert that change, and merge the PR, like this PR. These tests are complete enough that once they pass, you'll know GCB is compatible with the next WP version. There's no need for manual testing. |
kienstra
commented
Mar 13, 2024
| setupEditor( post ); | ||
|
|
||
| if ( setEditedPost ) { | ||
| setEditedPost( post.type, post.id ); |
There was a problem hiding this comment.
Fixes a console error in WP 6.5:
wp.data.dispatch( 'core/editor' ).setupEditorState is deprecated since version 6.5. Please use wp.data.dispatch( 'core/editor' ).setEditedPost instead.
dreamwhisper
approved these changes
Mar 13, 2024
|
Thanks so much for approving this, @dreamwhisper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
6.5. We'll need to release this before6.5.Testing instructions
Not needed