Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In e2e tests, set the PHP version to 8.1 #118

Merged
merged 16 commits into from
May 6, 2022
Merged

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Apr 22, 2022

Changes

  • In e2e tests, set the PHP version to 8.1
  • Gives us a little more confidence in 8.1 compat, but e2e tests usually won't fail from PHP notices

Testing instructions

Not needed, a sanity check would be great!

@kienstra
Copy link
Contributor Author

kienstra commented Apr 22, 2022

The e2e tests pass with PHP 8.1, though there are some PHP deprecation notices:

Starting d063fb1047aac1fd2147665b3d54e584_mysql_1 ... 
Starting d063fb1047aac1fd2147665b3d54e584_mysql_1 ... doneStarting d063fb1047aac1fd2147665b3d54e584_wordpress_1 ... 
Starting d063fb1047aac1fd2147665b3d54e584_wordpress_1 ... done^@^@[22-Apr-2022 16:47:41 UTC] PHP Deprecated:  Return type of Genesis\CustomBlocks\Blocks\Controls\ControlAbstract::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/wp-content/plugins/project/php/Blocks/Controls/ControlAbstract.php on line 137
Deprecated: Return type of Genesis\CustomBlocks\Blocks\Controls\ControlAbstract::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/wp-content/plugins/project/php/Blocks/Controls/ControlAbstract.php on line 137
[22-Apr-2022 16:47:41 UTC] PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /var/www/html/wp-content/plugins/project/php/Blocks/Loader.php on line 545
Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /var/www/html/wp-content/plugins/project/php/Blocks/Loader.php on line 545

There are several uses of FILTER_SANITIZE_STRING that I'll have to replace, that should take less than a day.

@kienstra
Copy link
Contributor Author

kienstra commented Apr 22, 2022

It's probably going to be too much trouble to run PHPUnit tests on PHP 8.0 and 8.1.

We'd have to change the test setup.

@kienstra kienstra requested a review from dreamwhisper May 2, 2022 21:46
@kienstra kienstra marked this pull request as ready for review May 2, 2022 21:46
@kienstra
Copy link
Contributor Author

kienstra commented May 6, 2022

@dreamwhisper, thanks, you're a hero!

@kienstra kienstra merged commit cfc13e8 into develop May 6, 2022
@kienstra kienstra deleted the update/e2e-php-verion branch May 6, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants