Don't instantiate unused analytics client #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GA isn't used anywhere, so it won't do much good. Also, this has a copy-pasted GA ID from Genesis Blocks.
To follow what install-wp-tests.sh does
kienstra
commented
Mar 22, 2022
|
|
||
| // @ts-ignore | ||
| window.GcbAnalytics = { | ||
| GAClient: new GAClient(), |
There was a problem hiding this comment.
This isn't used anywhere, at least yet.
And I mistakenly kept in the copied GA_ID from Genesis Blocks.
kienstra
commented
Mar 23, 2022
| echo "Error: Built tag already exists: $built_tag" | ||
| exit 2 | ||
| echo "Error: Built tag already exists: $built_tag" | ||
| exit 2 |
There was a problem hiding this comment.
Just changes spaces to tabs to match other file
|
Hi @johnstonphilip, |
dreamwhisper
approved these changes
Mar 23, 2022
|
@dreamwhisper, thanks a lot for reviewing this, and on your birthday! 🎂 |
|
Code looks straightforward and fine - smoke test showed no problems that I could see. |
johnstonphilip
approved these changes
Mar 23, 2022
|
@johnstonphilip, thanks a lot for testing this and approving it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GA_IDthat's copied from Genesis Blocks. I need to fix that.Testing instructions