Update package.json dependencies
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be able to get the version from .nvmrc
kienstra
changed the title
node-sass with sasspackage.json dependencies
kienstra
commented
Feb 22, 2022
| @@ -38,8 +30,7 @@ jobs: | |||
| name: php | |||
| steps: | |||
| - checkout | |||
| - node/install: | |||
| node-version: '14.18.1' | |||
| - node/install | |||
There was a problem hiding this comment.
It looks like the orb now finds the Node version from .nvmrc
kienstra
commented
Feb 22, 2022
| @@ -5,7 +5,6 @@ | |||
| "plugin:import/recommended", | |||
| "plugin:eslint-comments/recommended", | |||
| "plugin:jsx-a11y/recommended", | |||
| "plugin:testing-library/recommended", | |||
There was a problem hiding this comment.
It sounds like this doesn't exist anymore
kienstra
commented
Feb 22, 2022
| php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" | ||
| EXPECTED_SIGNATURE=$(curl -s https://composer.github.io/installer.sig) | ||
| ACTUAL_SIGNATURE=$(php -r "echo hash_file('sha384', 'composer-setup.php');") | ||
| [[ "$EXPECTED_SIGNATURE" == "$ACTUAL_SIGNATURE" ]] && sudo php composer-setup.php --install-dir=/bin --filename=composer || exit 1 |
There was a problem hiding this comment.
Not related to this PR, just a simplification
kienstra
commented
Feb 22, 2022
| @@ -0,0 +1,5 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
To replace .babelrc
kienstra
commented
Feb 22, 2022
| $black: #000; | ||
| $dark-gray-900: #191e23; | ||
| $dark-gray-800: #23282d; | ||
| $dark-gray-700: #32373c; | ||
| $dark-gray-600: #40464d; | ||
| $dark-gray-500: #555d66; // Use this most of the time for dark items. | ||
| $dark-gray-500: #555d66; |
There was a problem hiding this comment.
To address new linting rules. I'm not sure why this isn't allowed.
kienstra
requested review from
johnstonphilip,
marksabbath,
dreamwhisper and
mikemcalister
dreamwhisper
approved these changes
Mar 2, 2022
|
Thanks a lot, @dreamwhisper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
package.jsondependenciesnode-sasswithsassTesting instructions