Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing nav containing deleted element throws error #13

Closed
i-just opened this issue Aug 28, 2018 · 6 comments
Closed

Editing nav containing deleted element throws error #13

i-just opened this issue Aug 28, 2018 · 6 comments
Assignees
Labels
bug 🕷 Something isn't working

Comments

@i-just
Copy link

i-just commented Aug 28, 2018

When trying to edit a nav which contains deleted element, I get the following error:

Impossible to invoke a method ("getCpEditUrl") on a null variable.
in vendor/studioespresso/craft-navigate/src/templates/_edit.twig at line 58 

I'm using Navigate v1.1.1. Can you please have a look into it?

@janhenckens
Copy link
Member

Thanks for catching this!
I’m on holiday at the moment, will be back on Sunday. Fix should be out soon after!

@janhenckens janhenckens self-assigned this Aug 29, 2018
@janhenckens janhenckens added the bug 🕷 Something isn't working label Aug 29, 2018
janhenckens added a commit that referenced this issue Sep 2, 2018
@i-just
Copy link
Author

i-just commented Sep 3, 2018 via email

@janhenckens
Copy link
Member

Ha yes, will do! That's the downside of quick fixes when the brain is still in holiday mode :)
Coming right up!

@janhenckens janhenckens reopened this Sep 3, 2018
@janhenckens
Copy link
Member

Fixed in 1.1.3. Should be in the store soonish, there are some issues with updates coming through there so hang on for a bit.

@janhenckens
Copy link
Member

It's in the store!

Thanks again for reporting this and for using my plugin :)

@i-just
Copy link
Author

i-just commented Sep 4, 2018

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🕷 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants