Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement \core_privacy\local\request\core_userlist_provider #74

Closed
ewallah opened this issue Dec 16, 2018 · 4 comments
Closed

Implement \core_privacy\local\request\core_userlist_provider #74

ewallah opened this issue Dec 16, 2018 · 4 comments

Comments

@ewallah
Copy link
Contributor

ewallah commented Dec 16, 2018

The latest changes in the privacy api introduced the \core_privacy\local\request\core_userlist_provider. So the mod_studentquiz privacy provider should include a get_users_in_context and delete_data_for_users function.
@KietChan
Copy link

KietChan commented Jan 2, 2019

Hi @frankkoch ,

I've pushed the implementation for this interface, could you please help me to review it.

Many thanks, and happy new year :).
Kiet

@ewallah
Copy link
Contributor Author

ewallah commented Jan 2, 2019

It looks like this code is doing the job.

However Travis complains about duplicated lines in privacy_test.php (562-569 745-752) and coding style (Closing brace must be on a line by itself).

@KietChan
Copy link

KietChan commented Jan 7, 2019

Thanks ewallah
I've updated the code, Travis should be happy now.

@muqiuq
Copy link
Collaborator

muqiuq commented Jan 20, 2019

Could you please make a pull request?

@KietChan KietChan mentioned this issue Jan 21, 2019
Closed
@muqiuq muqiuq closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ewallah @muqiuq @KietChan