Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major performance issues with this parser enabled while editing Lua code #32

Open
no-more-secrets opened this issue Oct 22, 2023 · 5 comments

Comments

@no-more-secrets
Copy link

Hi there, I just had to disable this plugin as it is creating major performance issues in my editor at least when editing certain file types. Here is my setup:

OS: Linux; confirmed to happen on both Pop!_OS 20.04 and RedHat8, so probably not distro-dependent.
Editor: Neovim v0.9.1
tree-sitter-comment version: latest

It only seems to happen though when editing Lua files. In my treesitter neovim config file I have parsers for many languages enabled, including "lua" and "comment". When I enable "comment" it makes my editor slow to a crawl, to the point where I can hardly scroll the cursor around. And it seems to get worse the longer the editing session. When I uninstall only the "comment" parser, then everything is fine.

Any idea? Sorry I can't give a reproducer, but just wanted to bring this to your attention.

@stsewd
Copy link
Owner

stsewd commented Feb 23, 2024

Hi, are you still able to reproduce this? There have been several improvements in Neovim to better handle injections. There is also the possibility that the parser got slow with the introduction of URLs, haven't done any tests related to that, so it's just a possibility.

@no-more-secrets
Copy link
Author

@stsewd Actually for the last couple of months tree-sitter-comment doesn't seem to work for me any longer at all (i.e. my TODOs and NOTEs are no longer highlighted). I don't think I changed anything config-wise, I think it was just after an update of some kind, either nvim or plugins. Has anything recently changed with the plugin that would require a different/new configuration?

@stsewd
Copy link
Owner

stsewd commented Feb 24, 2024

I'm using the latest versions of both, everything works for me. Make sure you have the parser installed :TSInstall comment.

@no-more-secrets
Copy link
Author

Yes I have it installed and enabled (I also tried uninstalling/reinstalling). I'm going to try doing a more thorough investigation to see if the issue is some other aspect of my config that is interfering, and come back at some point.

Would you expect tree-sitter-comment to be interfered with in any way by enabling LSP syntax highlighting? I suppose that's not the issue since I tried disabling that to no avail, but am just curious if anything LSP-related could interfere.

@stsewd
Copy link
Owner

stsewd commented Feb 26, 2024

Would you expect tree-sitter-comment to be interfered with in any way by enabling LSP syntax highlighting? I suppose that's not the issue since I tried disabling that to no avail, but am just curious if anything LSP-related could interfere.

I know there is a problem with one Lua's LSP that overrides highlight for comments, see #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants