-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Think about versioning in the report json #5
Comments
I propose that we use semver for both the schema and report components where the report components follow the major.minor versions from the schema, but do not need to have the same patch versions. |
Perhaps we should also include the version in the report schema json. So on the dashboard, the correct one can be loaded from unpkg |
Yes that is what I meant as well. The json report should have the schema version it was generated from included as a value. |
Cool, I like what you're saying. Luckily, unpkg adheres to semver. See https://unpkg.com/. So should just be able to reference it like I would suggest keeping |
@nicojs the schema version is currently '1' according to the schema. This is not yet in line with the proposal to use semver. |
What do you mean with that exactly? The version in the I would like to make a small adjustment:
I think we shouldn't allow patch releases of the schema. It doesn't make sense, as the schema does not have an implementation. I would keep minor versions for additions to the schema and major versions for breaking changes (we should have those as little as posible). The major.minor version of the schema should always be in sync with the major.minor version of the mutation-test-report-app element. For example:
|
That is what I suggested as well, so I agree :)
|
For example: when showing the report on the dashboard, it needs to know which version to use.
The text was updated successfully, but these errors were encountered: