Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic linker fixups #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dynamic linker fixups #4

wants to merge 3 commits into from

Conversation

bnoordhuis
Copy link
Member

I've only been able to make this work on Linux so far (see below) and I'm not 100% convinced that linking against a specific .so is a good idea so feedback is welcome.

It only seems to work on OS X when I execute install_name_tool -id @rpath/libocci.dylib /path/to/libocci.dylib first, else -Wl,-rpath,<path> has no effect...

/cc @raymondfeng

@bnoordhuis
build: fix formatting in binding.gyp
c6cc2ee 
* Fix indentation.
* Strip trailing whitespace.
* Use ' and " consistently.

Cosmetic changes only, no functional changes.
@raymondfeng
Copy link
Member

For MacOS, we can run install_name_tool as part of the loopback-oracle-build script which creates a tarball including the oracle instant client and our prebuilt binary.

@bnoordhuis
Copy link
Member Author

Apropos nothing, I wonder if this is a bug in the oracle libraries... Changing the call in oracle_bindings.cpp to createConnection("", "", "") produces the same behavior.

==21453== Conditional jump or move depends on uninitialised value(s)
==21453==    at 0x8B36DD6: __intel_sse2_strlen (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0x851021B: kpugemlc (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0x7F392A0: kpusebfc (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0x7F391B0: kpusebf (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0x7F83707: kpuatch (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0x8D9A50D: kpuspsessionget (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0x8C0B388: OCISessionGet (in /opt/oci/libclntsh.so.12.1)
==21453==    by 0xAF2530B: oracle::occi::ConnectionImpl::openConnection(OCIEnv*, OCIError*, void*, unsigned int, void*, unsigned int, void*, unsigned int, void*, unsigned int, unsigned int, void*, unsigned int, oracle::occi::Connection::Purity, oracle::occi::StatelessConnectionPool::PoolType) (in /opt/oci/libocci.so.12.1)
==21453==    by 0xAF2032D: oracle::occi::ConnectionImpl::ConnectionImpl(oracle::occi::EnvironmentImpl*, std::string const&, std::string const&, std::string const&) (in /opt/oci/libocci.so.12.1)
==21453==    by 0xAF1E885: oracle::occi::EnvironmentImpl::createConnection(std::string const&, std::string const&, std::string const&) (in /opt/oci/libocci.so.12.1)
==21453==    by 0x7868208: OracleClient::EIO_Connect(uv_work_s*) (oracle_bindings.cpp:138)
==21453==    by 0x95864C: worker (threadpool.c:74)
==21453==    by 0x94E008: uv__thread_start (uv-common.c:322)
==21453==    by 0x5A69F32: start_thread (pthread_create.c:309)
==21453==    by 0x5D73DEC: clone (clone.S:111)

bnoordhuis added 2 commits May 9, 2014 20:59
@bnoordhuis
build: set RPATH when linking
57c78f4 
Add the directory containing libocci to the dynamic linker search path
so strong-oracle users don't have to set LD_LIBRARY_PATH at run-time.
@bnoordhuis
test: set DYLD_BIND_AT_LAUNCH / LD_BIND_NOW
c9ba5ef 
Make it harder for dynamic linker errors to slip through by forcing the
tests to run with all dynamic symbols resolved.
@bnoordhuis
Copy link
Member Author

For MacOS, we can run install_name_tool as part of the loopback-oracle-build script which creates a tarball including the oracle instant client and our prebuilt binary.

That means it needs a relative RPATH? I assume it's the same for Linux?

@raymondfeng
Copy link
Member

Yes, we'll have the following module layout:

node_modules

  • strong-oracle
    • build/Release/oracle_bindings.node
  • instantclient
    • (dylibs)

@stiXits stiXits mentioned this pull request May 14, 2016
Open
@bnoordhuis bnoordhuis removed their assignment Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnoordhuis @raymondfeng