Enable ES6/ES2015 goodness #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove ES5 parser exception from .eslintrc - Configure Karma to use Babel to transpile ES6 sources to ES5, because PhantomJS does not support ES6 - Upgrade es5-shim to es6-shim
|
@bajtos That means I can use ES6 code style in the test part ? What about in core ? |
We will be able to use ES6 code style everywhere, as we are already doing in other LoopBack packages. See also http://loopback.io/doc/en/contrib/style-guide.html |
superkhau
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
because PhantomJS does not support ES6
Related issues
cc @pthieu