custom remote method doesn't check for accepts type

[0xgeert]

Given a remote method defined as (partial):

accepts: [{ arg: 'payload', type: ['object'], http: { source: 'body' }, required: true}] ,

I expected the method to return a 400 bad request or something when the argument payload (i.e.: the body of the post in the case) isn't an array of objects. However, it seems to take any valid json.

Is this expected?

[frankcarey]

Yeah, I have a similar issue where when I set type to 'number', there isn't any error when passing a string like 'asdf' into the explorer. The 'asdf' then comes into the custom method as NaN, so I had to add some custom checking for that like so:

    myModel.getWeather = function(latitude, longitude, cb) {
      // rest connector doesn't check properly. Strings come in
      // as NaN when type accepts.type == 'number';
      if(isNaN(latitude) || isNaN(longitude)) {
        var err = new Error();
        err.status = 400;
        err.message = "Lat and long must be numbers";

        return cb(err);
      }

      //Do my usual stuff knowing that these should be numbers now.
      cb();
    }

[bajtos]

I believe the arguments are converted in SharedMethod.prototype.invoke, it should be reasonable easy to add validations.

@gebrits @frankcarey Would you mind submitting a pull request implementing the changes you need?

[bajtos]

Closing as a duplicate of #2092 where a more recent discussion is taking place.