-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leftovers from 2.0 #391
Comments
|
Re: remove sharedCtor and remoted prototype methods @bajtos I urge you to not drop remoted prototype methods, as discussed before. It is in heavy use whenever you want to add functionality in a sensible manner, I can assure you. Why even consider dropping this? @altsang I thought we arrived at 2.0 yesterday, yet there's still some breaking changes listed here? What's the final ETA? |
@fabien I apologize for the confusion. 2.0 has definitely arrived and there won't be any breaking changes until 3.0. This GH issue lists items there were mentioned in #276 (the pull request for 2.0 branch). My intention was to move them to a place where they are easy to find, then review them and decide which of them are still relevant. I have renamed the issue from "2.0 TODO" to "Leftovers from 2.0" to make this more clear.
If I remember it correctly, this item was added by @ritch. I don't recall what was the reasoning behind that. We are thinking about providing a more generic approach for creating scopes/hierarchies, prototype methods then may become a specific application of this generic approach. |
The migration guide is available here: http://docs.strongloop.com/display/LB/Migrating+existing+apps+to+version+2.0 |
@bajtos thanks for the clarification, leftovers makes a lot more sense. Regarding the prototype methods, @ritch chimed in on a discussion that he appreciated the heads-up concerning this functionality, and that it shouldn't be dropped just like that. The functionality it provides is something that should make it into the refactored approach to scoping/hierarchies. |
We aren't dropping remote prototype methods. On Jul 23, 2014, at 6:30 AM, Miroslav Bajtoš [email protected] wrote:
|
@ritch hey Ritchie, isn't this line trying to create a new object even if there is one that just needs to be updated accordingly? I am trying the full-stack example with mongodb connection and bulk-update POSTs are returning HTTP500 because of this. I haven't dug into the replication system enough to really make sense out of all the moving parts but just wanted to ask here to see if there is something trivial I am missing (for instance; do I need to use the rectify changes remote function instead of bulk update to resolve this?) |
@seckin please open a new github issue to discuss that. |
I don't believe this should have the "doc" label; although some of the items are doc items, many are not. If and when we create specific doc issues from the items on the list, then those should have the "doc" label. |
Agreed 👍 |
Considering that this issue is over 18 months old and the issues in the list were not important enough to fix them so far, I doubt we will ever work on them. I am closing this issue. |
List of leftovers from #276.
Model
)removeloopback.createModel()
in favor ofModel.extend()
DataModel
toPersistedModel
app.docs()
#392DataModel
mixins in favor of simple delegationDataModel
methods should delegate to the dataSource directlyDataModel#replicate()
intoReplication
class.DataModel#bulkUpdate()
intoBulkUpdate
class.DataModel#diff()
intoDiff
class.removeModel
autoAttachapp.remoteObjects()
ACL
=>AccessControl
andoptions.acls
tooptions.acl
.sharedCtor
and remoted prototype methods (probably not - see sharedCtor not working - examples borked strong-remoting#73)DataModel
methodsapp.boot()
into its own separate moduleACL
into its own separate moduleList of issues assigned to 2.0 milestone but not implemented in 2.0:
app.model
should report unknown options #169The text was updated successfully, but these errors were encountered: