Document strictObjectIDCorecion flag #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loay
force-pushed
the
strictObjectIDCorercion
branch
2 times, most recently
from
a72faad to
ee70b2d
Compare
ssh24
suggested changes
Jun 22, 2017
| }, | ||
| ... | ||
| } | ||
| ``` |
0candy
suggested changes
Jun 22, 2017
README.md
Outdated
| @@ -181,6 +181,25 @@ make benchmarks | |||
|
|
|||
| The results will be output in `./benchmarks/results.md`. | |||
|
|
|||
| ## strictObjectIDCoercion flag | |||
|
|
|||
| In version 1.17.0, where the id is of string type, is being converted to ObjectID when the string length is 12 or 24 and has the format of an ObjectID i.e /^[0-9a-fA-F]{24}$/. To avoid this issue, the strictObjectIDCoercion flag should be set to true in the model-definiton file. | |||
There was a problem hiding this comment.
nitpick: it is being converted instead of is being converted
There was a problem hiding this comment.
I reformatted the whole sentence
0candy
approved these changes
Jun 22, 2017
0candy
reviewed
Jun 22, 2017
README.md
Outdated
| @@ -181,6 +181,66 @@ make benchmarks | |||
|
|
|||
| The results will be output in `./benchmarks/results.md`. | |||
|
|
|||
| ## strictObjectIDCoercion flag | |||
|
|
|||
| In version 1.17.0, where the id of string type is being converted to ObjectID, when the string length is 12 or 24 and has the format of an ObjectID i.e /^[0-9a-fA-F]{24}$/. To avoid this issue, the strictObjectIDCoercion flag should be set to true in the model-definition file. | |||
loay
force-pushed
the
strictObjectIDCorercion
branch
from
0434604 to
b5fedda
Compare
b-admike
reviewed
Jun 22, 2017
README.md
Outdated
| @@ -183,7 +183,7 @@ The results will be output in `./benchmarks/results.md`. | |||
|
|
|||
| ## strictObjectIDCoercion flag | |||
|
|
|||
| In version 1.17.0, where the id is of string type, is being converted to ObjectID when the string length is 12 or 24 and has the format of an ObjectID i.e /^[0-9a-fA-F]{24}$/. To avoid this issue, the strictObjectIDCoercion flag should be set to true in the model-definition file. | |||
| In version 1.17.0, where the id of string type is being converted to ObjectID, when the string length is 12 or 24 and has the format of an ObjectID i.e /^[0-9a-fA-F]{24}$/. To avoid this issue, the strictObjectIDCoercion flag should be set to true in the model-definition file. | |||
There was a problem hiding this comment.
Suggestion: In version 1.17.0, if you have an 'id' property of type string, it will be converted to ObjectID when its length is 12 or 24 and has the format of an ObjectID i.e /^[0-9a-fA-F]{24}$/.
README.md
Outdated
| @@ -228,9 +228,9 @@ module.exports = function(app) { | |||
| name: 'Bar', | |||
| }], function(err, result) { | |||
| if (err) throw err; | |||
| console.log('\nCreated employees: ' + util.inspect(result, 4)); | |||
| console.log('\nCreated instances of my model: ' + util.inspect(result, 4)); | |||
There was a problem hiding this comment.
myModelName actually :)
loay
force-pushed
the
strictObjectIDCorercion
branch
from
b5fedda to
3e7b0bb
Compare
b-admike
approved these changes
Jun 22, 2017
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting up a proper workaround for mongodb 1.17 version bug when string type ids are being converted to objectIDs
Related issues
connect to https://github.com/strongloop-internal/scrum-apex/issues/146