Docker/setup #227
Merged
Docker/setup #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnes512
reviewed
Nov 12, 2019
docker.setup.js
Outdated
| // we don't pass any node flags, so we can call _mocha instead the wrapper | ||
| const mochaBin = require.resolve('mocha/bin/_mocha'); | ||
|
|
||
| process.env.CLOUDANT_DATABASE = 'test-db'; |
There was a problem hiding this comment.
Can we change this to testdb? Most of our default db names are testdb 😄
There was a problem hiding this comment.
@agnes512 sure whatever name makes more sense to lb-next tests~
jannyHou
commented
Nov 13, 2019
docker.setup.js
Outdated
| const fs = require('fs-extra'); | ||
|
|
||
| // we don't pass any node flags, so we can call _mocha instead the wrapper | ||
| const mochaBin = require.resolve('mocha/bin/_mocha'); |
There was a problem hiding this comment.
@agnes512 I will remove this broken line :p
jannyHou
force-pushed
the
docker/setup
branch
2 times, most recently
from
e7312cc to
a91ff11
Compare
jannyHou
force-pushed
the
docker/setup
branch
2 times, most recently
from
0faa2c9 to
a3a7e25
Compare
jannyHou
force-pushed
the
docker/setup
branch
from
a3a7e25 to
141fdc1
Compare
7 tasks
dhmlau
added a commit
that referenced
this pull request
Jan 27, 2020
* chore: update copyright year (Agnes Lin) * replace couchdb3 docker img with a stable version (Agnes Lin) * docs: add partition document (#232) (Janny) * fixup!: fix the dependency version (#233) (Janny) * feat: query with partition field (#230) (Janny) * chore: improve issue and PR templates (Nora) * feat: add partitioned find (#229) (Janny) * add docker setup script (#227) (Janny) * feat: partitioned index (#225) (Janny) * fix CODEOWNERS file (Diana Lau) * update docker image (#224) (Janny)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Status: code works but need cleanup.
Setup a couchdb 3 docker image for travis testing (without running tests in this repo).
My test app runs ping tests successfully on travis and get the exported env configs, see jannyHou/test-couchdb-travis#1
This script is created to unblock loopbackio/loopback-next#3437
Related issues
Checklist
guide