From 586632c4195d83e826914831c5f5dfb00521040e Mon Sep 17 00:00:00 2001 From: Matthias Naber Date: Thu, 11 Apr 2024 17:02:57 +0200 Subject: [PATCH 1/5] feat: new element for paper's own widgets --- stroeer/core/v1/article.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/stroeer/core/v1/article.proto b/stroeer/core/v1/article.proto index 98b7e177..9b6efd0c 100644 --- a/stroeer/core/v1/article.proto +++ b/stroeer/core/v1/article.proto @@ -270,6 +270,7 @@ message Article { * | `AGENCY` | author, contains one `metadata` [`Asset`][a] | * | `EDGE_SIDE_INCLUDE` | `` that must be resolved server-side for SEO reasons, otherwise similar to `OEMBED` | * | `CITATION` | oEmbed, contains one `metadata` [`Asset`][a]. Todo: sample | + * | `PAPER_WIDGET` | widget or embed that is handled directly by the paper front end rendering | * * [a]: article_%DB%B0_element_%DB%B0_asset.html * [e]: #element @@ -291,6 +292,7 @@ message Article { AGENCY = 7; EDGE_SIDE_INCLUDE = 8; CITATION = 9; + PAPER_WIDGET = 10; } /** @CodeBlockEnd */ From dafb02798582f48765e3f77793ac501593590f34 Mon Sep 17 00:00:00 2001 From: Jan Meischner Date: Fri, 12 Apr 2024 09:07:01 +0200 Subject: [PATCH 2/5] rename type --- stroeer/core/v1/article.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stroeer/core/v1/article.proto b/stroeer/core/v1/article.proto index 9b6efd0c..fadeadaf 100644 --- a/stroeer/core/v1/article.proto +++ b/stroeer/core/v1/article.proto @@ -270,7 +270,7 @@ message Article { * | `AGENCY` | author, contains one `metadata` [`Asset`][a] | * | `EDGE_SIDE_INCLUDE` | `` that must be resolved server-side for SEO reasons, otherwise similar to `OEMBED` | * | `CITATION` | oEmbed, contains one `metadata` [`Asset`][a]. Todo: sample | - * | `PAPER_WIDGET` | widget or embed that is handled directly by the paper front end rendering | + * | `INTERNAL_WIDGET` | widget or embed that is handled directly by the paper front end rendering | * * [a]: article_%DB%B0_element_%DB%B0_asset.html * [e]: #element @@ -292,7 +292,7 @@ message Article { AGENCY = 7; EDGE_SIDE_INCLUDE = 8; CITATION = 9; - PAPER_WIDGET = 10; + INTERAL_WIDGET = 10; } /** @CodeBlockEnd */ From 484ee9d4234e3866f308d2d20bc06553318b75a2 Mon Sep 17 00:00:00 2001 From: Jan Meischner Date: Fri, 12 Apr 2024 09:07:20 +0200 Subject: [PATCH 3/5] fix typo --- stroeer/core/v1/article.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stroeer/core/v1/article.proto b/stroeer/core/v1/article.proto index fadeadaf..ef05c9fb 100644 --- a/stroeer/core/v1/article.proto +++ b/stroeer/core/v1/article.proto @@ -292,7 +292,7 @@ message Article { AGENCY = 7; EDGE_SIDE_INCLUDE = 8; CITATION = 9; - INTERAL_WIDGET = 10; + INTERNAL_WIDGET = 10; } /** @CodeBlockEnd */ From aacb17e220fbef4f9bbc6f3415ce7de00905fdb3 Mon Sep 17 00:00:00 2001 From: Jan Meischner Date: Fri, 12 Apr 2024 09:12:52 +0200 Subject: [PATCH 4/5] Update stroeer/core/v1/article.proto Co-authored-by: Patrick Dahms --- stroeer/core/v1/article.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stroeer/core/v1/article.proto b/stroeer/core/v1/article.proto index ef05c9fb..d995fcb0 100644 --- a/stroeer/core/v1/article.proto +++ b/stroeer/core/v1/article.proto @@ -270,7 +270,7 @@ message Article { * | `AGENCY` | author, contains one `metadata` [`Asset`][a] | * | `EDGE_SIDE_INCLUDE` | `` that must be resolved server-side for SEO reasons, otherwise similar to `OEMBED` | * | `CITATION` | oEmbed, contains one `metadata` [`Asset`][a]. Todo: sample | - * | `INTERNAL_WIDGET` | widget or embed that is handled directly by the paper front end rendering | + * | `INTERNAL_WIDGET` | widget or embed that is handled directly by the front end rendering | * * [a]: article_%DB%B0_element_%DB%B0_asset.html * [e]: #element From 0d6835c133b2f5cf3259e2d7294af5e4bc71f988 Mon Sep 17 00:00:00 2001 From: Jan Meischner Date: Fri, 12 Apr 2024 09:14:41 +0200 Subject: [PATCH 5/5] format comment --- stroeer/core/v1/article.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stroeer/core/v1/article.proto b/stroeer/core/v1/article.proto index d995fcb0..1f7989df 100644 --- a/stroeer/core/v1/article.proto +++ b/stroeer/core/v1/article.proto @@ -270,7 +270,7 @@ message Article { * | `AGENCY` | author, contains one `metadata` [`Asset`][a] | * | `EDGE_SIDE_INCLUDE` | `` that must be resolved server-side for SEO reasons, otherwise similar to `OEMBED` | * | `CITATION` | oEmbed, contains one `metadata` [`Asset`][a]. Todo: sample | - * | `INTERNAL_WIDGET` | widget or embed that is handled directly by the front end rendering | + * | `INTERNAL_WIDGET` | widget or embed that is handled directly by the front end rendering Todo: sample | * * [a]: article_%DB%B0_element_%DB%B0_asset.html * [e]: #element