This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
Fix various things #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a top-level list of strings contains an empty string, the provider helper library seems to report a nil instead of an empty string. The issue does not reproduce for sets of strings, or for lists of strings that are inside another object. The empty string doesn't actually make sense, but we don't want to blow up with a panic. A provider panic causes terraform to report an extremely scary error message. We'd rather let the JSON go to SFx where it'll be rejected with a 4xx, whose error output is much more approachable.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @cory-stripe