Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: code coverage is not reported to Coveralls.io #956

Closed
antonblr opened this issue Apr 11, 2023 · 1 comment · Fixed by #958
Closed

CI: code coverage is not reported to Coveralls.io #956

antonblr opened this issue Apr 11, 2023 · 1 comment · Fixed by #958
Labels

Comments

@antonblr
Copy link
Contributor

Describe the bug

This is GitHub Action CI related issue not a stripe-python package bug.

Code coverage reports have stopped since #888 (last coveralls.io/github/stripe/stripe-python report is dated as of October, 2022).

Is COVERALLS_REPO_TOKEN secret set for the repo ?

- name: Calculate and publish coverage
  run: make coveralls
  if: env.COVERALLS_REPO_TOKEN && matrix.python-version == '3.10'  # <-- is COVERALLS_REPO_TOKEN set in repo secrets ? 
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}  # <-- might be needed here as well?

It might be necessary to inject it to the step.env as well (as shown above ^)

Also, I've noticed that make coveralls essentially runs all the tests again. Perhaps you can grab coverage results from Test with pytest (3.10) step (make ci-tests also runs coverage, but via pytest plugin)? Or, skip Test with pytest step for 3.10 altogether.

To Reproduce

Check any recent GitHub Action CI runs, e.g. https://github.com/stripe/stripe-python/actions/runs/4632402230/jobs/8196419932
Calculate and publish coverage step is always skipped.

Expected behavior

GitHub Action CI Calculate and publish coverage step runs for python 3.10.

Code snippets

No response

OS

n/a

Language version

n/a

Library version

n/a

API version

n/a

Additional context

No response

@pakrym-stripe
Copy link
Contributor

Nice catch, @antonblr! We decided to keep running tests twice to keep the workflow simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants