Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated error definitions #1489

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Jul 25, 2022

r? @kamil-stripe

Removes error definitions that we kept for back-compat.

Changelog

  • Remove deprecated Stripe.Stripe***Error types. Prefer the Stripe.errors.Stripe***Error instead.

Copy link
Contributor

@kamil-stripe kamil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Add changelog entries?

@pakrym-stripe pakrym-stripe merged commit 9b2f616 into sdk-release/next-major Jul 26, 2022
kamil-stripe added a commit that referenced this pull request Aug 1, 2022
* Delete files that are no longer being generated. (#1478)

* Remove deprecated error definitions (#1489)

* Generate stripe-node with breaking changes (#1491)

* Generate stripe-node with breaking changes

* Update CustomerSource enum

* Generate files

* Fix type in test

* Fix tests

Co-authored-by: Dominic Charley-Roy <[email protected]>
Co-authored-by: pakrym-stripe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants