Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refund struct missing failure_reason #929

Closed
jredl-va opened this issue Aug 23, 2019 · 4 comments · Fixed by #930
Closed

Refund struct missing failure_reason #929

jredl-va opened this issue Aug 23, 2019 · 4 comments · Fixed by #930
Assignees

Comments

@jredl-va
Copy link
Contributor

When implementing the stripe refund webhook it seems as though failure_reason is missing from the struct: https://github.com/stripe/stripe-go/blob/master/refund.go#L48

Link to the documentation: https://stripe.com/docs/api/refunds/object

Is there any specific reason that this field is excluded?
Would you accept a PR adding this field?

@remi-stripe remi-stripe self-assigned this Aug 23, 2019
@remi-stripe
Copy link
Contributor

@jredl-va No specific reason except that we must have missed that field. I can take the fix if you want but we would definitely love a PR if you're up for doing the work :)

@jredl-va
Copy link
Contributor Author

If you have the time it would be most appreciated. We have for the time being implemented our own proxy object that contains this field when unmarshalling.

@remi-stripe
Copy link
Contributor

@jredl-va This was fixed in 62.5.0, thanks again for the report!

@jredl-va
Copy link
Contributor Author

Thanks for the quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants