Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

Use libdefs so that flow in user projects doesn't break. #6

Closed
michelle opened this issue May 11, 2017 · 5 comments
Closed

Use libdefs so that flow in user projects doesn't break. #6

michelle opened this issue May 11, 2017 · 5 comments

Comments

@michelle
Copy link
Collaborator

See: facebook/flow#1996 (comment)

@asolove
Copy link

asolove commented Aug 16, 2017

(Ok, sorry a second time. I got a little excited about working on elements stuff and kinda ran over here and started asking questions. I'm gonna go chill and come back when I actually have context and understand what's going on.)

@asolove-stripe
Copy link
Contributor

Now that flow by default doesn't test type problems inside node_modules, do we think this is mostly resolved? Or do we still want to think about libdefs to also fix type issues in users' code?

@techieshark
Copy link

@asolove-stripe +1 for what looks like a suggestion to export the Flow type definitions.

Actually, for folks using checkout it'd be great if there were flow definitions provided via flow-typed.

Use case: working on a react app with Flow, and want to type-check StripeCheckout.configure(stripeCheckoutOptions) and stripeCheckoutOptions.token(token) callback function.

@beaucollins
Copy link

beaucollins commented Nov 13, 2019

We've been using this for our Flow based repo:

https://gist.github.com/beaucollins/1c6147026375fa63482727f411d83c75

We'll be updating it for 6.x and hopefully submitting to flow-typed.

@sashko-stripe
Copy link
Contributor

Closing this as it's a relatively old issue and this project has migrated to React Stripe.js. If you believe this is still important, please re-open it there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants