feat: Update operator to use cached resources #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update operator to use cached resources rather than calling Kubernetes directly. * Move code to construct secret data into a separate class to make it easier to switch to DependentResource type later. Signed-off-by: Katherine Stanley <[email protected]>
* Add primaryToSecondary mapper for Kafka and rename Mapper class. Signed-off-by: Katherine Stanley <[email protected]>
katheris
force-pushed
the
useCachedResources
branch
from
1444fac to
f55957d
Compare
scholzj
approved these changes
Aug 23, 2023
csviri
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
LGMT
just one note, not sure what the intention was, but the implementation does not use the actual dependent resource feature from JOSDK,
https://javaoperatorsdk.io/docs/dependent-resources
Would suggest to merge this as it is, and might be worth to experiment with that. Happy to help with it.
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katherine Stanley [email protected]