Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Hexa.NET.ImGui to the latest #177

Open
VaclavElias opened this issue Nov 20, 2024 · 2 comments
Open

chore: Update Hexa.NET.ImGui to the latest #177

VaclavElias opened this issue Nov 20, 2024 · 2 comments
Assignees
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note p4 Low priority, nice to have

Comments

@VaclavElias
Copy link
Collaborator

Not urgent. There is some error when upgrading to 2.2.2.

@VaclavElias VaclavElias added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Nov 20, 2024
@Doprez
Copy link
Collaborator

Doprez commented Nov 20, 2024

That is a strange issue, it seems to be complaining about a empty ID for a window but it seems like it should be there and is not empty...

Checking the below line, it clearly shows that it has the name of the relevant created BaseWindow.

collapsed = !Begin(name, ref open, flags);

error:

Assertion failed: id != window->ID && "Cannot have an empty ID at the root of a window. If you need an empty label, use ## and read the FAQ about how the ID Stack works!", 
file D:\a\Hexa.NET.ImGui\Hexa.NET.ImGui\cimgui\imgui\imgui.cpp, line 11416

Not sure what I'm missing here.

Note: it has broken in version Hexa.ImGUI 2.2.0 since the ImGUI 1.91.4 release.

@VaclavElias VaclavElias added the p4 Low priority, nice to have label Nov 22, 2024
@VaclavElias
Copy link
Collaborator Author

Interesting. We could ask the author, but it isn't urgent. Just noted here, so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note p4 Low priority, nice to have
Projects
None yet
Development

No branches or pull requests

2 participants