Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Render bridges of streets over each other #44

Closed
Akasch opened this issue Feb 10, 2018 · 13 comments
Closed

Render bridges of streets over each other #44

Akasch opened this issue Feb 10, 2018 · 13 comments

Comments

@Akasch
Copy link

Akasch commented Feb 10, 2018

While browsing the map I have noticed that it is not possible in the current style to see that one could not go from one street to the other as there is a bridge. The Issue can be seen here:

Streetcomplete-Style: https://map-data.de/#map=19/53.63997/10.00312&style=streetcomplete-light
Openstreetmaps: https://www.openstreetmap.org/#map=19/53.63997/10.00312

On a side note: The I think the gates would be a good addition to, as one can't go into the airfield.

Or a little to the east:
https://map-data.de/#map=19/53.63790/10.00908&style=streetcomplete-light
https://www.openstreetmap.org/#map=19/53.63790/10.00908

@rugk
Copy link
Contributor

rugk commented Feb 10, 2018

Ah that map data link is nice, how did you get it? In the Readme I can only see Tangram Play links.

@Akasch
Copy link
Author

Akasch commented Feb 10, 2018

@rugk it is my domain (mostly for serving the vector tiles at the moment) and I wanted to play around a little bit, so it is a work in progress, you can see the ugly code over at https://github.com/Map-Data/map-data.de

@rugk
Copy link
Contributor

rugk commented Feb 10, 2018

Indeed would be good to find an alternative, especially as Tangram Play does not work anymore (because of the MapZen shutdown).

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 10, 2018

Tangram Play does work here: https://tangram.city/play/

@rugk
Copy link
Contributor

rugk commented Feb 10, 2018

Ah, okay so it is just your Readme link. Always shows "Request error with a status of Not Found".

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 10, 2018

Yeah, because it links to the local files...
Just replace the import statement with the following:

import:
    - https://raw.githubusercontent.com/ENT8R/streetcomplete-mapstyle/master/global.yaml
    - https://raw.githubusercontent.com/ENT8R/streetcomplete-mapstyle/master/layers/land.yaml
    - https://raw.githubusercontent.com/ENT8R/streetcomplete-mapstyle/master/layers/labels.yaml
    - https://raw.githubusercontent.com/ENT8R/streetcomplete-mapstyle/master/layers/roads.yaml

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 10, 2018

I changed the URLs in the Readme and now it should work as expected... I only need to replace them with the commented section each time I open a PR to update the mapstyle in the app

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 10, 2018

Regarding this issue: I think it might be related to #9...

@westnordost
Copy link
Member

I changed the URLs in the Readme and now it should work as expected... I only need to replace them with the commented section each time I open a PR to update the mapstyle in the app

Or, you can have two branches and sync them before each PR.

@westnordost
Copy link
Member

Regarding this feature request: This would definitely be nice, but I do not really know how this can be solved (without introducing a lot of style code).
One would think that the feature.sort_rank would take care of this (plus tunnels).

@ENT8R
Copy link
Collaborator

ENT8R commented Feb 10, 2018

Adding

bridges:
  filter:
    - is_bridge: true
  draw:
    lines:
      outline:
        cap: butt
        order: 400

to the default road-outline works quite well:

@ENT8R ENT8R closed this as completed in 97979ae Feb 10, 2018
@ENT8R
Copy link
Collaborator

ENT8R commented Feb 10, 2018

The solution 🔝 works in all cases I've seen so far... If you are seeing a wrong rendered bridge, just tell me here!

@HolgerJeromin
Copy link

I think multiple crossing bridges with layer 1 and 2 would not work. But they are rare and no special handling needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants