Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

show highway=busway #147

Closed
matkoniecz opened this issue Jul 18, 2024 · 16 comments
Closed

show highway=busway #147

matkoniecz opened this issue Jul 18, 2024 · 16 comments
Assignees

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Jul 18, 2024

see https://wiki.openstreetmap.org/wiki/Tag:highway%3Dbusway

requested in streetcomplete/StreetComplete#5749

@matkoniecz
Copy link
Member Author

@Joxit are there plans/chances to include highway=busway in Jawg vector tiles?

@matkoniecz
Copy link
Member Author

if implemented - reopen streetcomplete/StreetComplete#5749 or extract quests from it (surface quest?)

@Joxit
Copy link

Joxit commented Jul 18, 2024

Hi there, thank you for your feedback. After a quick review of the tag, we decide to add it to our tileset streets-v2.

I will be get back to you when it's done 😄

@Joxit
Copy link

Joxit commented Jul 18, 2024

Could you assign the issue to me ?

@matkoniecz
Copy link
Member Author

Done!

@Joxit
Copy link

Joxit commented Jul 24, 2024

Hi there, we did the release for highway=busway yesterday, the new tiles are rolling up gradually.

You can check the documentation for a custom styling: https://www.jawg.io/docs/apidocs/maps/streets-v2/#road

The data will be available in the road layer, the assigned class is service and the type is busway.

In this example Carrefour de Pompadour is a busway + bridge.

Screenshot_20240724-110816

@matkoniecz
Copy link
Member Author

So it sounds like map style changes are not needed...

@mnalis
Copy link
Member

mnalis commented Jul 24, 2024

Interestingly, for me that Carrefour de Pompadour is shown correctly (as dashed road) on https://streetcomplete.github.io/streetcomplete-mapstyle/ (Tangram StreetComplete test), so Jawg vector tiles definitely work nicely:

chrome_screenshot_streetcomplete github io_tangram

but not on https://streetcomplete.app/map-jawg/ (MapLibre) - there only grey bridge outline is shown.

chrome_screenshot_streetcomplete app_maplibr

Unfortunately that MapLibre web map version does not allowing showing/editing used style (like the Tangram web test version allows), so it's hard to say why it doesn't seem to render it, but I guess should be mapstyle related.

@Joxit
Copy link

Joxit commented Jul 24, 2024

I have the busway on the maplibre example too.

Could you try the MapLibre version on a private tab or without cache ?

Don't forget, some tiles can be in your browser cache and some other are still outdated on some of our datacenters.

@mnalis
Copy link
Member

mnalis commented Jul 24, 2024

I have the busway on the maplibre example too.

It was in a private window, and with F12 / disable cache... However, you are correct, busway does show there too when I zoom in a little more:

chrome_screenshot_streetcomplete app_zoom2 chrome_screenshot_streetcomplete app_zoom1

What threw me off is that highway=service south of that roundabout is rendered normally at the same zoom level that highway=busway isn't. Is that intentional or?

@matkoniecz
Copy link
Member Author

AFAIK maplibre counts zoom levels in a different way...

If you zoom out on Tangram, will busways disappear before other service roads?

@mnalis
Copy link
Member

mnalis commented Jul 24, 2024

If you zoom out on Tangram, will busways disappear before other service roads?

It is hard to say -- both seem to remain visible on Tangram even when I zoom out so much that the roads are barely recognizable on the map. It's only on MapLibre style that the issue happens when zoomed in. Perhaps it has custom zoom override for highway=service but not for highway=busway?

Anyway, it does not seem to be Jawg related, but a StreetComplete MapLibre style issue.

@westnordost
Copy link
Member

westnordost commented Jul 24, 2024

The MapLibre style looks correct to me. Excerpt:

...
{
  "id": "roads-service",
  "source": "jawg-streets",
  "source-layer": "road",
  "filter": [
    "all",
    ["in", ["get", "class"], ["literal", ["service", "driveway"]]],
    ["==", ["geometry-type"], "LineString"],
    ["!", ["in", ["get", "structure"], ["literal", ["bridge", "tunnel"]] ]]
  ],
  "type": "line",
  "paint": {
    "line-color": "#fff",
    "line-width": ["interpolate", ["exponential", 2], ["zoom"], 13.0, 0.5, 16.0, 3.0, 24.0, 768.0],
    "line-opacity": ["interpolate", ["exponential", 2], ["zoom"], 14.0, 0.0, 15.0, 1.0]
  },
  "layout": {"line-cap": "round", "line-join": "round"}
},
...

i.e. all class=driveway and class=service should be covered. There is no logic in the style that differentiates between busways and other service roads.

@westnordost
Copy link
Member

Anyway, I can also not reproduce this on https://streetcomplete.app/map-jawg/, so, closing. Thanks for adding highway=busway to Jawg!

@mnalis
Copy link
Member

mnalis commented Jul 25, 2024

Now it works for me in MapLibre too. Perhaps some zoom levels were not yet rendered, leading to the issue...

@Joxit
Copy link

Joxit commented Jul 25, 2024

You are welcome 😊

Thank you for your feedback again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants