Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housenumber quest doesn't show up if only building=yes is tagged #821

Closed
5 tasks done
tobylorenz opened this issue Feb 1, 2018 · 4 comments
Closed
5 tasks done

Comments

@tobylorenz
Copy link

General

Affected key(s) (or tags) to be modified: addr
Question asked: Why isn't the housenumber asked, if there is just building=yes is there?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by everyone from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of elements have the same answer (No spam)
  • 🕓 Applies to a reasonable number of elements (Worth the effort)

Ideas for implementation

I think the filter expression in the housenumber quest is incomplete. I have many houses in my neighborhood, which are tagged only with building=yes. For these houses the quests doesn't show up to set a housenumber. So maybe it's sufficient to just add building=yes to the filter list (HOUSES_WITHOUT_HOUSENUMBERS).

Element selection:
The filters should not just include building=residential, but also building=yes.

Metadata needed:
It might be that building=yes is not appropriate, but often it is the initial value, if the buildings are drawn from satellite maps, but no local survey took place.

Proposed GUI:
The existing GUI is perfect. It just should quest, also in case where only building=yes is tagged.

@matkoniecz
Copy link
Member

matkoniecz commented Feb 1, 2018

Duplicate of #297

We do not want this quest for garages, sheds etc.

@ENT8R
Copy link
Contributor

ENT8R commented Feb 1, 2018

This will be fixed by #774

@rugk
Copy link
Contributor

rugk commented Feb 1, 2018

Also BTW, the issue template is meant for proposing new quests, not for asking questions about existing ones.

@tobylorenz
Copy link
Author

@matkoniecz Yes, right. building=yes would really flood the streets with quests ;-)

@ENT8R That's indeed the best approach for this. As soon as the building type is properly set, the quest for the housenumber will appear automatically.

@rugk Indeed it's written in the template "If you are not suggesting a new quest, ignore this issue template. Otherwise we kindly ask you to fill it out."... Just wanted to do it properly, but read over this important exception ;-)

So, I propose to close this issue then. Nothing remains to be done in this context. Thank you all for the quick reply. I'll happily continue to answer quests then ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants