Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show roof:levels quest on buildings where both building:levels and roof:height are present #5996

Closed
Mbodin opened this issue Oct 31, 2024 · 1 comment

Comments

@Mbodin
Copy link

Mbodin commented Oct 31, 2024

Note: this is about a quest which I believe is disabled by default, so this feature request is low priority ☺

Use case
Here is a concrete example: https://www.openstreetmap.org/way/32603233
This building basically has the following tags:

building=office
building:levels=1
roof:height=0.5
roof:shape=hipped

However, on StreetComplete, the “How many levels above the basement does this building have?” quest appear (with precompleted building:levels as 1): it basically wants me to fill-in the roof:levels tag. This seems to me as a contradiction with what is explained in this section of the wiki: https://wiki.openstreetmap.org/wiki/Simple_3D_Buildings#Usage_of_height,_roof:height,_building:levels,_roof:levels

Proposed Solution
I would disable the “How many levels above the basement does this building have?” quest when both building:levels and roof:height are already present.

@westnordost
Copy link
Member

Makes sense.

Also excluded from the quest buildings that have height + roof:height set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants