Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show AddCrossingKerbHeight for crossing without crossing #5476

Closed
Helium314 opened this issue Feb 6, 2024 · 3 comments
Closed

Show AddCrossingKerbHeight for crossing without crossing #5476

Helium314 opened this issue Feb 6, 2024 · 3 comments

Comments

@Helium314
Copy link
Collaborator

With the recent changes to the crossing quests, AddCrossingKerbHeight is almost never asked because it requires a crossing tagged.
Since SC now tags crossing only for informal crossings, the quest will rarely show up when adding crossing details in SC only.

Proposed solution: skip the crossing requirement, or also ask if crossing:signals or crossing:markings are tagged.

@HolgerJeromin
Copy link
Contributor

ref #5471

@westnordost
Copy link
Member

Hmm, not sure why there was the check for crossing at all. After all, the quest is asked for any crossing, regardless of what is the value of crossing in the end. So, rather than to complicate the filter, I think it can simply be removed.

@westnordost
Copy link
Member

Ah, well, the AddCrossingType quest was only asked for crossings that are not crossings with driveways. So, we should filter that out here, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants