-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no default maxheight in Israel #5458
Comments
Are you sure that Israel has no legal size limit for vehicles driving on public roads? Also, in https://www.openstreetmap.org/way/881547522/history
in such case if user selected "there is no sign" they were wrong, but SC requires no changes. (but I would expect this to be not true and at least some places being unsigned - maybe sign fallen off or was stolen) EDIT: edited about identify match/mismatch |
There are limitations on vehicles, depending on their size. There is also a procedure for police approval for handling oversized transportation. However, this is not a limitation on the roads.
This is not my changeset and not my comment, but this is correct. There should be a maxheight sign for every height obstacle on any Israeli (vehicle) road.
I think we can agree that, regardless of the locality:
A missing maxheight sign in Israel does not mean that "the physical height is sufficient for the country specific height limit of general traffic", as the wiki explains If a SC user selects a "there is no sign" in Israel, then according to the wiki, SC should use the IMO, an explicit |
ops, sorry
I agree! That is why StreetComplete then asks whether
( If first option is taken then
But SC asks more, to be more specific. |
StreetComplete in such case asks for more info to be able to tag Is this additional knowledge how SC works is resolving your concerns? |
Since the notion of a "default height" has no meaning in Israel, as explained in length above, both Please use the meaningful and useful |
Why you think so? You mention "There is also a procedure for police approval for handling oversized transportation." so it means that there is size limit for vehicles below which they are not an oversized vehicle (this typically is the same size as typical HGV/TIR/large truck operating on roads).
Are you claiming that this tag would be wrong also on road where any non-oversized vehicle would fit vertically? |
@yrtimiD also feel free to answer that question, here or at https://www.openstreetmap.org/changeset/146652481 |
I was about to write exactly the same words, to me the There is another issue, I noticed that most "default" reports was in places where there are proper and clear signs. (guess people reported while driving and just didn't notice the sign). As result, this quest was hidden from other users without chance to fix. |
Is Or is such situation impossible for some reason? (why?)
In such case: please comment on changeset that people made and ask them to be more careful |
From my experience - in Israel there will be a clear sign on the bridge for each lane. And even if there is declared global default - only very special people will know it (unlike max speed, for example, which is well known to every driver)
Of course, I send them all messages with explanation, but it feels like these people are not "pure" OSM editors and contribute only via SC, so they don't know what are these "default" or "below_default" means at all. I'd just prefer to avoid entering incorrect values in the first place. |
Since there is a requirement for maxheight signs in Israel, the lack of a sign cannot be interpreted as "the physical height is sufficient for the country specific height limit of general traffic". It should be interpreted as "there is no sign". @matkoniecz, |
Do you have an Android phone? Have you seen how this question is presented there? Can you look at it in app?
it is not interpreted this way by StreetComplete. If that is the problem, then you report nonexisting problem. After user marks "no sign" answer, then StreetComplete additionally asks whether
It is worth distinguishing this cases.
I am trying to understand root of the reported problem so it can be fixed properly.
In cases where But also willing to be convinced (see for example sidewalks of cycleways discussion). But with even higher priority, I want to understand situation, and what specifically went wrong so it can be solved. Changing app behaviour without understanding what is being fixed is asking for trouble, in many ways. |
I do have android with SC and this quest is one of my favorites. |
I could be wrong (I have only written few SC quests), but I think that SC quests currently does not have an ability to modify quests answers depending on the country. There is only ability to disable showing the quest completely in some country, but that is obviously sub-optimal. (although I do seem to recall discussion about allowing the code to inspect the country, I cannot find it right now, but AFAIR it was ultimately rejected. Perhaps someone would like to get consensus on that and implement code which can then be reused on quests?) So ideally, the solution chosen would be applicable and useful in the whole world (instead of disabling maxheight quest in Israel).
|
You are wrong, it is possible to distinguish countries in the form. |
Hey, don't cheer me, I did not offer a solution, I just read the first sentence of mnalis last answer and thought I'd correct this. In fact, I didn't follow this ticket otherwise as @matkoniecz was already in dialogue with @zstadler (I don't need to be involved in every ticket) |
we are cheering to the fact that country checking is already exists, so the solution should be pretty easy to implement :) |
@mnalis ,
In current implementation the "no sign" option is slightly misleading as at the end
Unfortunately, in our case there is no clear definition of what it might mean. the no_sign is way cleaner.
That's actually the main problem - at the moment somebody adds
We did discussion in the telegram, mostly in hebrew.
No-no, currently quest is very useful and contributes significantly more than harm, no reason to disable it. BTW, the "default" value was not super-populate before SC introduced this quest back in 2019 (~10k) and exploded to >90k since. |
@matkoniecz could you summarize the outcome of this discussion? Would you say it should be implemented as suggested? Which tag to use? |
I don't know how else can we say that wasn't already said. Nevertheless, I'll rephrase yet again: Israel has no default height in terms signage. Therefore tagged a road with OSM tagging should stand by itself, regardless of the site/app used for that tagging. Currently, SC asks a question that is irrelevant for Israel and uses this respond to choose between two irrelevant tags. @westnordost As far as I can see, SC Does not add a |
That is exactly the same situation as elsewhere. But I would expect that, also like elsewhere, Israel has standard maximum height for regular vehicles (trucks will be typically having this size). And it is useful to distinguish between "unsigned, there is space for full sized vehicles" and "unsigned, full sized truck will not fit". And if for one reason or another making this distinction is impossible/unwanted then it applies not only in Israel. |
Uhm, now I am confused, too. As @matkoniecz wrote, you won't find "default max height" signs anywhere, so I fail to understand in what way Israel differs from elsewhere. (Someone wrote that all maxheights are always signed in Israel? Well, then, allowing users to tag
Well, believe me, it does. Your link leads to a changeset that was done in the frame of the |
I suspect that situation is the same as elsewhere - but there may be local preference to one tagging over another. Or maybe wiki page in Hebrew is badly translated? We have seen this type of confusion before (commas vs semicolons in opening hours where misunderstanding was result of badly translated German wiki page). |
Regardless to the country, I'm as a driver without truck license will prefer to not answer a question about "full sized vehicle" at all. I really don't know how high these vehicles are and in most cases can't even say if a bridge is high enough. Giving such "unprofessional" answer might be very problematic, and from UX point of view user is kind of forced to choose one of options instead of just finishing with "no sign". (I observe this on many changes in Israel done with SC. People selected absolutely random value where maxheight sign was absent or person just missed it) |
I see, but then this is not specific to Israel. I.e. this should be discussed in the community forums or mailing lists. I'd be fine if SC always tagged something along the lines of Question is, why was it implemented with default/below_default in the first place? Maybe back when it was implemented, only default/below_default were considered valid? This is the PR that added the quest back then: #960 |
I read through it and these are the relevant comments/threads: |
So, it looks like already back then, there have been concerns about using That Now, So, StreetComplete could tag Optionally, one of the following things could be done:
for both suggestions the assumption is that if the maxheight is not signed on a motorway, it will be high enough for any large truck, plus it would be quite unsafe for a pedestrian to measure it, anyway. I tend towards the second option. |
I would not do this, there are some really silly cases of road technically being motorway but... If such assumption can be reliably made - then it can be applied in processing data. |
... Thus replacing (removing) Users who really care and wish to add extra details to those unsigned maxheights would use
I agree, better not to add |
I actually find the |
The usefulness of If you answer |
When answering "there is no sign", currently a dialog pops up that asks whether tall trucks fit under the bridge. In that dialog, we could simply add a third option "I can't tell" that tags |
That crossed my mind, too, but I always found this dialog unnecessarily complex for the mapper. And it doesn't really lift that much of a burden from the mapper, as then he'd need to decide if he's sure about it. And how sure is sure? - after all, the mapper is still asked to estimate if it is higher than 4.5m or not. Anyway, I am not set on this, I am just voicing my opinion that I'd like to use this to eliminate that dialog altogether. In case there are no further arguments, should we have a vote, or...? |
It kind of would be nice to be able to answer just "no sign" and still be able to tag blatant cases (2m high building passage, 40m clearance under a bridge) but I can live with eliminating it altogether. |
Understood. On the other hand I for example have no idea whatsoever how high "tall" truck as opposed to "short" truck is. I am also quite bad at estimating how wide/high something is, and whether something else (which I don't even see at that time!) is wider/taller than that. I also have no idea what actual legal limits are (even in my home country, much less when visiting another country) 🤷
Perhaps solution to address the both issues might be:
It would:
|
So, in short
Hm, it seems to me that it just moves the issue about that it is problematic to estimate whether something is above or below 4.5 in height one quest later. After all, it is conceivable that the user is not able to measure it for other reasons than it being so tall that measuring with AR does not work properly. |
I think the main benefit would be that Thus only (For example in my case, even with AR available, I have only enabled AR quest for cycleways because I care about bicycle infrastructure a lot, and even then it is only present in 20% of my presets. All other quests which require AR/meter are only present in "Everything" preset that I keep for rare moments when I am really bored in almost-100%-solved areas). |
I see, well, I see that rather as an argument to completely remove it, because also the I'll remove it, then. |
The initial request was for Israel only because I was not familiar with the situation elsewhere. |
It happened already, see 2c1493b (just commited, not yet released) |
StreetComplete enters an invalid
maxheight=default
for ways in Israel. There is no default height in Israel.Moreover, any effort to remove the erroneous tags is doomed to fail, as new StreetComplete edits keep adding them.
How to Reproduce
Open the maxheight quest and enter
maxheight=default
for a way in Israel.For example, https://www.openstreetmap.org/changeset/138343697
Expected Behavior
The
default
value should not be an option for maxheight in Israel.Versions affected
All
The text was updated successfully, but these errors were encountered: