Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop overlay, existence quests etc.: Include clubs #5244

Closed
westnordost opened this issue Sep 11, 2023 · 3 comments
Closed

Shop overlay, existence quests etc.: Include clubs #5244

westnordost opened this issue Sep 11, 2023 · 3 comments

Comments

@westnordost
Copy link
Member

Clubs, for example chess clubs, culture clubs, fishing clubs, freemasons etc. etc. are often situated in a rental that could otherwise be a shop or office. Hence, it would make sense to include them in the isShopExpressionFragment code.

@mnalis that would mean that maybe your list of things that should be changed if the place changes must be updated too.

@mnalis
Copy link
Member

mnalis commented Sep 15, 2023

@westnordost club is already present in KEYS_THAT_SHOULD_BE_REMOVED_WHEN_SHOP_IS_REPLACED:

"stonemason", "studio", "scuba_diving(:.*)?", "polling_station", "club", "collector", "books",

so if I understand it correctly, no further change is needed there?

@matkoniecz
Copy link
Member

@mnalis I though that it is about fetching common tags used by club= and not used by other shoplike objects (maybe there is club_theme or something not used by shops)

Should we update https://github.com/mnalis/StreetComplete-taginfo-categorize/blob/master/Makefile#L3 to find common tags used by clubs?

@mnalis
Copy link
Member

mnalis commented Feb 24, 2024

(Those are included now with #5501)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants