Do not ask for path segregation in case either bicylce or foot is set to "no"

[ironspock]

possible bug or enhancement on quest "How footway and bicycleway are segregated" (highway:path)

SC is asking for path segregation however the node already has a tag bicycle:no
(refer to https://www.openstreetmap.org/way/990523743)

I'm not sure whether it's happen often or maybe it's better to change the node from highway:path to highway:footway via JOSM/ID/etc.

Expected Behavior
Do not ask for segregation in those cases.

Versions affected
v53.3

[qugebert]

I think this part of the query is wrong:

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/segregated/AddCyclewaySegregation.kt

Line 21 in b623dcc

or highway ~ path|footway|cycleway and (footway:surface or cycleway:surface)

In this case, we have a match of the combination highway = path and footway:surface

Maybe
or highway ~ path|footway and cycleway:surface or highway = cycleway and footway:surface

[westnordost]

Oh, that is definitely a bug. Thank you for the input, I will have a look at it now.

[westnordost]

It was added by @matkoniecz in #4642 , not sure why though. I don't really understand why the filter is there in the first place. Maybe he remembers?

(In any case, @ironspock , the way is tagged a bit weird: As a highway=path but bicycle=no (so a highway=footway then??) and then a footway:surface is set even though that's the only thing there is.)

[matkoniecz]

Weird tagging is present there, I opened https://www.openstreetmap.org/note/3851707

I don't really understand why the filter is there in the first place. Maybe he remembers?

to handle some not fully tagged ways, also segregated is looked at by surface overlay in some places so being sure that it is tagged was useful

I guess that case like reported here is blatantly invalid rather than missing tagging and could be skipped (though it would anyway cause confusion in surface overlay anyway...)

And maybe surface overlay should not simply check segregated but look at more complex info.

[qugebert]

to handle some not fully tagged ways, also segregated is looked at by surface overlay in some places so being sure that it is tagged was useful

I see, footway:-Prefix indicates, that there is more than only a footway and vice versa.
And why not exclude the ways, where one of both is tagged with no ?

[matkoniecz]

And why not exclude the ways, where one of both is tagged with no ?

In plan on fixing it this way + open notes in places with such tagging.

See http://overpass-turbo.eu/s/1zG7 and http://overpass-turbo.eu/s/1zG9 for suspicious data - I opened some notes already, may open more later.