Changing shop type in shop overlay should cleanup old-shop secondary tags

[mnalis]

Use case
When one changes shop type in "Shops overlay", it does not cleanup old shop tags (including opening_hours=*) - and it should (IMHO).

That is not consistent with what happens when one changes the same shop type via Quest when one notices the shop changed (e.g. when answering any shop quest like Which customers visit this hairdresser? I can answer It does not exist and choose that there is different shop type now (e.g. butcher). That will remove opening_hours and other secondary tags related to old amenity/shop, as it should do).

As the same action is being performed (i.e. different shop type is now there), SC should behave the same regardless whether user uses Quest other answer or Shop overlay to change shop type.

Interestingly, when I change the name of the shop in the overlay, I do get asked if it's Different place now or Still the same place, and if I choose the former, the tags like opening_hours do get deleted, as they should.

---

Proposed Solution

I would suggest same question Different place now / Still the same place also get asked when changing shop type in Shops overlay, and secondary tags cleanup performed if it is different place now, just as it does when shop type is changed in Quest format via It does not exist.

Alternatively, when changing shop type in Shop overlay, always assume Different place now when type of the shop changes and perform tag cleanup (because, when hairdresser becomes butcher, it likely also changes its opening hours, payment methods, VAT id etc.)

(noticed it #5189 (comment) and went to check how it behaves and indeed it is behaving differently)

[rhhsm]

I would suggest same question Different place now / Still the same place also get asked when changing shop type in Shops overlay, and secondary tags cleanup performed if it is different place now, just as it does when shop type is changed in Quest format via It does not exist.

Alternatively, when changing shop type in Shop overlay, always assume Different place now when type of the shop changes and perform tag cleanup (because, when hairdresser becomes butcher, it likely also changes its opening hours, payment methods, VAT id etc.)

(noticed it #5189 (comment) and went to check how it behaves and indeed it is behaving differently)

I think different place now? should always be asked: when a hairdresser is changed to a butcher, it is indeed likely that it is a different shop, but when it is changed to a beauty salon, it's likely that is because the hairdresser has added additional services and it's still the same shop.

[westnordost]

So to summarize your request: StreetComplete should not assume that if the name of a place stays the same after changing the type, that it is still the same shop.

I assume you make this request because it happened to you during a mapping session? Please describe what happened.

[rhhsm]

I'm not sure whom you're asking, but I think it's probably safe to assume that if a shop name doesn't change, it's still the same shop (except when it's still noname=yes). In all other case it should be asked if it's still the same shop. It's a question that's very easy to answer, while having to unnecessarily enter opening hours again is much more work. I've come across shops that had changed but still kept the same opening hours as the previous shop (the hours were engraved in the shop window, and the new owner decided not to change them so he wouldn't have to replace the window...).

[westnordost]

It was directed at @mnalis. And yes, this is the reason why StreetComplete does not cleanup old-shop secondary tags when just changing the type but not the name.

[mnalis]

So to summarize your request: StreetComplete should not assume that if the name of a place stays the same after changing the type, that it is still the same shop.

I think it would be safer to ask it also when shop type changes but name remains the same, yes.

That should cover corner cases too, and (in my experience) shop/amenity changing type but not name is relatively rare, thus asking such question in those cases too should not excessively spam the user, so it should be both beneficial to data correctness and less confusing to the user to change the behaviour of Shops overlay so the question is always asked, no matter if only name or only type or both are changed.

I assume you make this request because it happened to you during a mapping session? Please describe what happened.

Primarily I was triggered by issue as linked at the bottom of original post, but if you need an example, I've recently edited e.g. node 2964594173 which kept the same name "Maslina" (meaning "Olive" - quite popular in Dalmatia) but changed type between restaurant to gift shop to restaurant over the years. I think owners only changed once, though. Opening hours did change on each iteration, as they catered to different clientele (but in this particular case, such details were not recorded in older node versions so it would by luck make no difference were it edited in SC Shops overlay, which it wasn't anyway)

Note however that I personally rarely if ever use Shops overlay feature of StreetComplete (as I noted before, I find it quite cumbersome to jump from overlay to overlay, and much easier to switch to EveryDoor and do what I need there before switching back to SC, partly also because of problem outlined in the linked issue), but if I were, I probably would've missed the fact that SC didn't ask nor clear old shop data and be confused about wrong data afterwards (just as I was surprised in the linked issue that changing type would not result in asking for new opening_hours as I expected).

[westnordost]

Well, you have a point. Asking is safer and at the same time should not spam the user because changing the shop type is something the user will not do often.