Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid does not disappear in some areas #5137

Closed
MakiWolf opened this issue Jul 12, 2023 · 13 comments
Closed

grid does not disappear in some areas #5137

MakiWolf opened this issue Jul 12, 2023 · 13 comments
Labels

Comments

@MakiWolf
Copy link

How to Reproduce

Happens in this area: https://www.openstreetmap.org/#map=17/46.43707/11.25036
grafik

Expected Behavior

Grid should disappear

Versions affected

53.2 from play store and latest build from source code (12.07.23)

@MakiWolf MakiWolf added the bug label Jul 12, 2023
@mnalis
Copy link
Member

mnalis commented Jul 13, 2023

@westnordost
Copy link
Member

If you tab out and then tab in again, is the grid gone, then?

@MakiWolf
Copy link
Author

MakiWolf commented Jul 13, 2023

I have made a screen recording now.
I did not notice this strange behavior in an other map area on the same device.
video:
https://github.com/streetcomplete/StreetComplete/assets/73300633/5762bc15-8356-4a61-ad03-aecf7ae60b24

@westnordost
Copy link
Member

Okay, but would you answer my question?

@mnalis
Copy link
Member

mnalis commented Jul 14, 2023

If you tab out and then tab in again, is the grid gone, then?

By "tab out/tab in" you mean switch to another app and then switch back to StreetComplete?

@westnordost
Copy link
Member

Yes.

@MakiWolf
Copy link
Author

Also happens when switching to another app or closing and reopening the app and also in an fresh install on Android Studio Emulator (tested with Pixel 4 API 29). Also happens on other cities like in Zirl (Austria) on the same longitude. https://www.openstreetmap.org/#map=19/47.26540/11.25033

grafik

@HolgerJeromin
Copy link
Contributor

I had this too when the feature was new.
Manually "search for quest here" fixed it.

@Helium314
Copy link
Collaborator

@MakiWolf interestingly when I downloaded this area, I initially got the bug on the right half of the displayed area. After turning the screen off and on again, it was the left half (also after restarting SC).

@riQQ
Copy link
Collaborator

riQQ commented Jul 30, 2023

Had the same issue with v53.3 in two different areas, after turning the screen off and back on with StreetComplete in the foreground the grid went away / it fixed itself both times.

I have the following reproducible behavior after somehow triggering the bug the first time.
Have two areas downloaded with changes in each.

  1. Open App and see grid
  2. Turn off the screen and turn it back on
  3. Grid is gone
  4. Move to change in other area via undo function (don't undo anything)
  5. Grid is there
  6. Go to step 2

@westnordost
Copy link
Member

This is very likely a problem in tangram-es, though, and hence, unfixable, since the former is not maintained anymore.

What we can do is to mitigate the issue. I had the impression that it more often occurs on lower zoom levels, so actually the grid is only turned on when zoomed in further already.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2023
@MakiWolf
Copy link
Author

MakiWolf commented Aug 1, 2023

This is very likely a problem in tangram-es, though, and hence, unfixable, since the former is not maintained anymore.

@westnordost Maybe streetcomplete should make a fork of it, if it is really not maintained anymore? That open Pullrequests could be merged. Because issues will become more on never android versions. Is this the repositority? https://github.com/tangrams/tangram-es

@westnordost
Copy link
Member

Well, someone could make a fork of it. I certainly won't because I am not experienced in C++ and thus couldn't properly review those PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants