Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'previous choice' option to Street lit overlay #4741

Closed
thibaultmol opened this issue Jan 8, 2023 · 21 comments · Fixed by #5461
Closed

Add 'previous choice' option to Street lit overlay #4741

thibaultmol opened this issue Jan 8, 2023 · 21 comments · Fixed by #5461

Comments

@thibaultmol
Copy link

Use case
Currently if you're doing a bunch of the "is this street lit?" Entries; it is requiring more clicks than I feel like it should be doing

Proposed Solution
I think similar to the quest where you have to select every Street has a cycle way; there should be a button when you're trying to answer the streetlights quest in the bottom left corner with the last answer you gave. That would half the amount of taps

@westnordost

This comment was marked as resolved.

@thibaultmol

This comment was marked as resolved.

@matkoniecz matkoniecz changed the title Add 'previous choice' option to Street lit quest Add 'previous choice' option to Street lit overlay Jan 9, 2023
@rhhsm

This comment was marked as off-topic.

@westnordost
Copy link
Member

Makes sense and is easy to implement. As always, PR is welcome.

Of course this should be implemented in the AImageSelectOverlayForm so that all overlay forms with the same UI will profit from that. (Currently only lit and the separate cycleway form, but also upcoming surface form)

@westnordost

This comment was marked as resolved.

@thibaultmol

This comment was marked as resolved.

@westnordost

This comment was marked as resolved.

@matkoniecz

This comment was marked as resolved.

@thibaultmol

This comment was marked as resolved.

@westnordost

This comment was marked as resolved.

@rhhsm

This comment was marked as resolved.

@HolgerJeromin

This comment was marked as off-topic.

@michalgwo

This comment was marked as off-topic.

@westnordost

This comment was marked as off-topic.

@rhhsm

This comment was marked as off-topic.

@qugebert
Copy link
Contributor

I would try on this next.
@FloEdelmann can you assign this to me, please?
Just one question: For the streetsidepuzzle-overlay there is a seperate ..controller-class. Should i keep this consistent and do it the same way or ist it okay if i put all code in the AImageSelectOverlayForm? (as it not as complex than the streetsidepuzzle)

@FloEdelmann
Copy link
Member

I'd say if it's not that complex, then putting it in AImageSelectOverlayForm is fine. If it turns out to be too much code, it can still be extracted into a controller afterwards.

@westnordost
Copy link
Member

For the (pre-draft - it is a branch) buildings overlay, I also considered refactoring the AImageSelectOverlay into a controller class, but at least to share functionality (which is the purpose of these controller classes), it didn't seem worth it to me.

@westnordost
Copy link
Member

Are you working on this, @qugebert ? If not, I'd like to take this.

@qugebert
Copy link
Contributor

Are you working on this, @qugebert ? If not, I'd like to take this.

Yeah, i started working on it but i would not have the time / concentration to continue this the next weeks so feel free.

@westnordost
Copy link
Member

Ah, well. Okay, then I take this over, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants