Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Manual trigger for AR Measure? #4636

Closed
contactobscurantist opened this issue Nov 16, 2022 · 1 comment
Closed

Feature request: Manual trigger for AR Measure? #4636

contactobscurantist opened this issue Nov 16, 2022 · 1 comment

Comments

@contactobscurantist
Copy link

Use case
Entering quest data for which AR Measure could be of use, but is not activated as a source.
Think tonnel or building passage Max Height quests, wall/fence height, leaving notes for new objects or details, etc.

Proposed Solution
Maybe a button for accessing AR measurements can be added inside one of the menus?
For example: Add Note -> AR Toolkit -> What would you like to measure? Distance|Height
Basic mockup included.
newnote-armeasure

If this feature is considered out-of-scope for StreetComplete, I think AR Measure part can be useful to many as a stand-alone app.

@westnordost
Copy link
Member

westnordost commented Nov 16, 2022

Hm well, it looks like the AR measure needs to be outsourced from StreetComplete (i.e. made into a separate non-GPL-licensed app) anyway as it turned out that Google's ARCore library is not actually licensed under the Apache license 2.0 as they claim it to be but is proprietary. Hence, the ARCore library cannot be part of GPL-licensed software like StreetComplete. The Google team that maintains ARCore seems uninterested in straightening out the issue (i.e. either documenting that it is not open source or actually following the license they declared for the product). Google is a big company and all and thus decisions make take a while but after 3 months, I don't have my hopes up that they intend to change anything in that regard. I.e. measuring stuff could remain in the app if they made it open source.

So anyway, long story short, I will soon be forced to remove AR measuring from the app and (maybe) reenable it by creating a separate (e.g. apache licensed) measuring app with which StreetComplete then communicates instead of doing the measuring itself. On the upside, this would enable other apps such as Vespucci, EveryDoor etc. to profit from this, plus, you could just do a measure independent of the app.

See google-ar/arcore-android-sdk#1538 (and #4289)

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants