Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a setting to disable sounds #2966

Closed
Outlet2048 opened this issue Jun 16, 2021 · 8 comments
Closed

Implement a setting to disable sounds #2966

Outlet2048 opened this issue Jun 16, 2021 · 8 comments

Comments

@Outlet2048
Copy link

Use case
I often use streetcomplete when I'm on the passenger seat. Most of the time I'm connected to the cars Bluetooth to play music. So being able to turn off the plop sounds each would be amazing.

Proposed Solution
Implement a setting that let's the user disable sounds

@Helium314
Copy link
Collaborator

I never had any sounds coming from StreetComplete, independent of any do not disturb or vibrate phone setting. So I guess you can disable it in the Sound category of the system settings (not sure which setting exactly)

@Outlet2048
Copy link
Author

I never had any sounds coming from StreetComplete, independent of any do not disturb or vibrate phone setting. So I guess you can disable it in the Sound category of the system settings (not sure which setting exactly)

Same for me before I switched phones
Previously I had a oneplus 6, now I have the oneplus 9 pro

All my phones have always been set to silent (no vibration, no notification sound)
The plop sound effect only occurs when the media volume is turned up
I can't remember ever having heard that on my previous phone

@westnordost
Copy link
Member

westnordost commented Jun 16, 2021

Exactly, the sounds will only be played if Settings.System.SOUND_EFFECTS_ENABLED is on.

If that setting does not exist (always on?) or does not work for a particular smartphone, this is really not an issue of the app.

@mnalis
Copy link
Member

mnalis commented Jun 16, 2021

Wait, StreetComplete has sounds? When? When quest is solved? (Not that I miss them terribly, but I'm genuinely wondering and would like to try them out)

I've never encountered any sounds from SC on at least 5 different phones (of makers Huawei, Xiaomi, LG, Samsung) neither on stock nor custom ROMs (CyanogenMod / LineageOS). Including the kids phone, which I'd wager has all possible sound settings maxed out all the time 😄

Quickly checking closest phone (Huawei P30 Pro with EMUI 11/Android 10), there are 4 Sound settings:

  • Ringer, Notifications
  • Alarms
  • Music, Video, Games
  • Calls

and all of them are at least halfway to full, yet I hear no sounds from SC v32.1

Can anyone (who has sounds) identify what is the setting called on their phone?

@Helium314
Copy link
Collaborator

On my phone, SOUND_EFFECTS_ENABLED is enabled when enabling touch sounds in settings.
But I still didn't hear anything from SC in a quick test.

@mnalis
Copy link
Member

mnalis commented Jun 16, 2021

Thanks for the pointer @Helium314!

I've looked around and found extra boolean settings by searching for touch and click instead of sound. It is called Screen touch here (which is separate from keypad tones toggle) and it is System haptics / more settings section.

It is extremely annoying even in the first few minutes (not just in SC but everywhere - every touch of the screen produces click noise), but it does seem to enable StreetComplete-specific sound effect too (not only click noise on every click of course as in OS/other apps, but also different plop noise on solving the quest).

Also, in addition to that Screen touch boolean setting, it seems that volume of effect additionally depends on:

  • volume of one of the click sounds (of which there appears to be two) seems to depend on Ringer, Notifications sound volume slider
  • volume of plop sounds (when quest solved) seems to depend of Music, Videos, Games sound volume slider
  • volume of second of click sounds seems unaffected by volume sliders

With my curiosity satisfied, I'll hurry to disable it again 😃

(I've updated FAQ with pointer)

@mnalis
Copy link
Member

mnalis commented Oct 9, 2022

@mnalis
Copy link
Member

mnalis commented May 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants