Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not rendering road over building correctly #292

Closed
winfried opened this issue Jun 4, 2017 · 9 comments
Closed

Not rendering road over building correctly #292

winfried opened this issue Jun 4, 2017 · 9 comments

Comments

@winfried
Copy link

winfried commented Jun 4, 2017

First of all compliments for streetcomplete, it is very accessible and fun!

At de 'Oudegracht' in Utrecht there is a side walk with terraces right at the water, with restaurants in cellars at the same level. Above it is the (main) street. To get the picture:

bezembrug

https://www.openstreetmap.org/#map=19/52.09157/5.11863 renders it correctly:
bezembrug_osm

Streetcomplete renders the structures under the main street above it, so it becomes hard to judge what road to answer the question about:
bezembrug_streetcomplete
I guess the layering has to be a bit more advanced...

@matkoniecz
Copy link
Member

Have you tried reporting it at https://github.com/tangrams/cinnabar-style/issues ? In my experience ( tangrams/cinnabar-style#26 ) it works quite well.

@matkoniecz
Copy link
Member

See also

The cinnabar style should be considered more or less read only. Maintaining a fork of this here adds too much maintenance work. I'd like to encourage you start a new very simple SC style from scratch, that only displays the information needed specifically for this app. This will be easy to maintain as well.

by @westnordost at #271 (comment)

@westnordost
Copy link
Member

Yes, this should be fixed upstream. Please create a bug in https://github.com/tangrams/cinnabar-style/issues or directly create a PR for that.

@nvkelso
Copy link

nvkelso commented Jun 9, 2017

@westnordost This will be a two part fix, so suggest:

  1. re-opening this issue to apply the fix described below in how you load Cinnabar, and
  2. you'll need to pull in a new version of Cinnabar style with a Mapzen fix tracked in Not rendering road over building correctly tangrams/cinnabar-style#30.

Per point 1 above, turn off 3d building extrusion in the style:

https://mapzen.com/documentation/cartography/api-reference/#building-extrusion

You need to set sdk_building_extrude: false in the global section. Since you're in Tangram ES it'd look something like:

map->loadScene(
    "https://mapzen.com/carto/refill-style/6/refill-style.yaml",
    false,
    { SceneUpdate("global.sdk_mapzen_api_key", "mapzen-xxxxxx"),
      SceneUpdate("global.sdk_building_extrude:", "false") }
);

The Mapzen documentation needs to be clarified, I'm tracking that in tangrams/cartography-docs#27.

The rest of the Mapzen basemap styles show the path correctly above the buildings, should be a minor fix to bring Cinnabar (and Zinc) into order.

@westnordost westnordost reopened this Jun 9, 2017
@westnordost
Copy link
Member

But I don't want to turn off extruding buildings. Extruded buildings are cool. If the bug can only be fixed by turning the feature off, I rather will not fix this bug.

@nvkelso
Copy link

nvkelso commented Jun 9, 2017

There's another option, here's that area in a new version of Refill I'm noodling with:

screen shot 2017-06-09 at 12 57 24

Most but not all terrace "basement" buildings are tagged layer=-1 here so filtering on that in the style I can tell them not to extrude. Fixing that will need a stylesheet change still. I'll leave it up to you if you want to keep this issue open to ingest the new stylesheet or not.

I'll track implementing that in the aforementioned Cinnabar issue.

@nvkelso
Copy link

nvkelso commented Jun 9, 2017

I've finished updating Cinnabar in tangrams/cinnabar-style@41f7108, planned for release Tuesday of next week.

@nvkelso
Copy link

nvkelso commented Jun 9, 2017

(So all other buildings will extrude but these "basements" – the only change you need to make is to pull in new version of the scene file).

@nvkelso
Copy link

nvkelso commented Jun 15, 2017

This fix is now live on the Mapzen CDN and released on Github:

https://github.com/tangrams/cinnabar-style-more-labels/releases/tag/v7.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants