Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge changesets (spanning large bbox) #2908

Closed
mnalis opened this issue May 25, 2021 · 2 comments
Closed

Huge changesets (spanning large bbox) #2908

mnalis opened this issue May 25, 2021 · 2 comments
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@mnalis
Copy link
Member

mnalis commented May 25, 2021

Use case
It seems that SC will happily create changesets covering large area. It is problematic for anyone watching the map as it will inform anyone in that bbox who is watching, and parsing/checking such a changeset is time consuming.

For example I've stumbled upon this one: https://www.openstreetmap.org/changeset/103921399

It should not be a problem during normal usage, but since SC allow users (after warning) to solve quests that are not related to their GPS position, it can produce such results.

Proposed Solution
Perhaps the changesets can be force-closed when:

  • quest answers change to another country
  • or when user answers the quest that is not close to their GPS coordinates?
  • or when top-left quest is too far away from bottom-right quest ?
@westnordost
Copy link
Member

That would require StreetComplete to know what elements are already in the changeset. It doesn't memorize which edits went into which changeset. I reckon that with some implementation effort, StreetComplete could memorize per edit into which changeset id it went. But then, the position of the edit that is about to be uploaded must be compared to the position of every single edit that has already been uploaded and if the smallest distance to any other edit is greater than X, create a new changeset.

But this adds a lot of complexity, really. You can create a large spanning bbox in every other editor as well. This kind of issue, that an extremely large bbox is created, should be extremely rare. Maybe occur once if someone is travelling and forgot to upload his contributions. So I don't see the necessity to solve this in the app.

Besides, large bboxes may point to that the particular user is misusing the app, i.e. using it not as a surveyor tool but contributing here and there. Thus, especially if it happens more often, it is better to contact him about it and instruct him. Like it has been done in the linked changeset. If SC would cut these kind of contributions into single changesets, then this information (about possible misuse) would be lost.

@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label May 25, 2021
@FloEdelmann
Copy link
Member

see also #2053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

3 participants