Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not asking material for highway=trunk_link #262

Closed
LivInTheLookingGlass opened this issue May 24, 2017 · 8 comments
Closed

Not asking material for highway=trunk_link #262

LivInTheLookingGlass opened this issue May 24, 2017 · 8 comments
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@LivInTheLookingGlass
Copy link

It would appear that some highway nodes don't ask you what material they are. highway=trunk_link is the example I've come across, but I would imagine that there are a few others.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented May 24, 2017

This is intentional. Here is the source:

private static final String[] ROADS_WITH_SURFACES = {
    // "trunk","trunk_link","motorway","motorway_link", // too much, motorways are almost by definition asphalt (or concrete)
    /*"service", */ // this is too much, and the information value is very low

Footway, cycleway, path are asked here: #133

@LivInTheLookingGlass
Copy link
Author

Hm.... I disagree with that, but not strongly enough to argue very hard about it. Unless it's a server-side problem, I would much rather have that be a toggle than a blanket ban. If @westnordost makes a ruling, I'll close without a fuss though.

I might consider putting in a PR if I can remember enough of the UX code to put the toggle in. I'm certainly willing to add in the necessary if statements.

@HolgerJeromin
Copy link
Contributor

@westnordost is against more settings.

@claudiush
Copy link

@gappleto97 Do you have real world examples where a trunk_link wouldn't be asphalted? Even the trunk roads I have been mapping in Iran and Turkmenistan are asphalted. I can think of a few trunk roads that have concrete surface, but that's about the only border case I can think of.

@LivInTheLookingGlass
Copy link
Author

All of the ones in my hometown are concrete. And there are several places in the northern parts of US-41 that have asphalt roads and concrete links.

@HolgerJeromin
Copy link
Contributor

In data usage asphalt or concrete is (nearly) identical. Probably that's why the surface quest gains much more value on smaller roads where we have unpaved surfaces which makes a real difference for routing engines.

@westnordost
Copy link
Member

See @HolgerJeromin

The data value for these roads is very low when we assume that every motorway or trunk will be paved by either asphalt or concrete because it really makes very little difference. Surface quests are repetitive enough as they are already.
Also, the app is more an "on foot" app. It would be much more efficient to add the surface tag to motorways etc. using sparse editing with JOSM + Overpass query.

@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

5 participants