Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddTactilePavingBusStop Quest Prompts for Railway and Subway platforms with confusing text #1584

Closed
peternewman opened this issue Sep 29, 2019 · 7 comments
Assignees
Labels

Comments

@peternewman
Copy link
Collaborator

How to Reproduce
This way offers the tactile paving quest:
https://www.openstreetmap.org/way/569053687

"Does the bus stop ... have tactile paving?"

Versions affected
Android 9, SC 14.1

Personally I'm not against the quest and I don't think it needs to be restricted, but it would be good if different text was displayed for the various transport types, similar to what was done to fix #806 .

In an ideal world, different icons would be good too, but I assume it then becomes lots of different quests and perhaps that isn't worth the coding overhead.

@matkoniecz
Copy link
Member

Thanks for spotting and reporting!

requires equivalent of 7780b73

AddBusStopName.kt, AddWheelchairAccessPublicTransport.kt, AddBusStopShelter.kt should be free from this bug

@peternewman
Copy link
Collaborator Author

peternewman commented Sep 29, 2019

Do we actually want to restrict (which seems unnecessary to me), or just have multiple worded prompts?

I'm hoping we can come up with some text that covers subway and railway as one (e.g. platform and train). I guess AddWheelchairAccessPublicTransport.kt might be inspiration there.

Edit, I see it actually has different text for different cases, which works well:
https://github.com/westnordost/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessPublicTransport.kt#L21-L35

@peternewman
Copy link
Collaborator Author

It should probably also cover railway=platform_edge:
https://wiki.openstreetmap.org/wiki/Tag:railway=platform%20edge?uselang=en-GB

@westnordost westnordost self-assigned this Oct 19, 2019
@peternewman
Copy link
Collaborator Author

Thanks @westnordost . It seems a shame not to cover railway and subway too though; whereas you've explicitly excluded them, or should I open a new enhancement/new quest to cover them?

@ghost
Copy link

ghost commented Oct 19, 2019

if were allready there we could add text for Tram stops tram=yes (and why not also Light Rail,Monorail Aerialway,Funicular)
and while were add it how about doing the same for amenity=ferry_terminal

@westnordost
Copy link
Member

Well, it could be a new quest. Code-wise, "new quests" are really really little work.

@peternewman
Copy link
Collaborator Author

Logically it feels like it probably just needs to be more different text prompts on the existing one, like where you added tram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants