-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddTactilePavingBusStop Quest Prompts for Railway and Subway platforms with confusing text #1584
Comments
Thanks for spotting and reporting! requires equivalent of 7780b73 AddBusStopName.kt, AddWheelchairAccessPublicTransport.kt, AddBusStopShelter.kt should be free from this bug |
Do we actually want to restrict (which seems unnecessary to me), or just have multiple worded prompts? I'm hoping we can come up with some text that covers subway and railway as one (e.g. platform and train). I guess AddWheelchairAccessPublicTransport.kt might be inspiration there. Edit, I see it actually has different text for different cases, which works well: |
It should probably also cover railway=platform_edge: |
Thanks @westnordost . It seems a shame not to cover railway and subway too though; whereas you've explicitly excluded them, or should I open a new enhancement/new quest to cover them? |
if were allready there we could add text for Tram stops |
Well, it could be a new quest. Code-wise, "new quests" are really really little work. |
Logically it feels like it probably just needs to be more different text prompts on the existing one, like where you added tram. |
How to Reproduce
This way offers the tactile paving quest:
https://www.openstreetmap.org/way/569053687
"Does the bus stop ... have tactile paving?"
Versions affected
Android 9, SC 14.1
Personally I'm not against the quest and I don't think it needs to be restricted, but it would be good if different text was displayed for the various transport types, similar to what was done to fix #806 .
In an ideal world, different icons would be good too, but I assume it then becomes lots of different quests and perhaps that isn't worth the coding overhead.
The text was updated successfully, but these errors were encountered: