-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPAIR incorrect data added with StreetComplete v8.0-beta1 and v8.0 #1222
Labels
Comments
westnordost
added
bug
help wanted
help by contributors is appreciated; might be a good first contribution for first-timers
labels
Oct 4, 2018
OSMCha has filters for the editor and the changeset comment: https://osmcha.mapbox.com |
Okay, currently using this. |
westnordost
removed
the
help wanted
help by contributors is appreciated; might be a good first contribution for first-timers
label
Oct 4, 2018
Repair for maxspeed is done for v8.0 and v8.0-beta1, continuing with cycleways... |
Alright, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What was broken?
In Version v8.0-beta1 and v8.0, the country detection was broken, it returned wrong results for a given geo position.
For some quests, StreetComplete shows a different UI for different countries and for a few, it also tags different things based on the country an element is in. With a broken country detection, the former could have led to misunderstandings by the users, the latter will have introduced wrong data.
This must be repaired.
What needs to be repaired?
To repair, all changesets generated by v8.0-beta and v8.0 (the former has been released on the 16th of September; the versions have been blocked for upload on 4th October, 20:00 UTC+2) for certain quest types need to be checked for errors.
I identified the following quests to potentially contain errors (in order by importance):
a) when answering that a road segment has no signed speed limit, the app tags
maxspeed:type=[ISO-COUNTRY_CODE]:[ROAD_TYPE]
. TheISO-COUNTRY_CODE
may be wrongb) otherwise, in countries that use miles per hour, the app tags
maxspeed=[input] mph
. It may be that the app wrongly addedmph
or vice-versaFor example the Dutch don't want the housenumber quest because they import all their addresses from an official source and thus don't need individuals to map housenumbers. The cycleway quest on the other hand is disabled in in most parts of the world, because in most parts of the world, there doesn't even exist the concept of a way designated for cyclists. Same goes for tactile pavings at bus stops and crossings etc etc.
So, point 1 and 2 must be checked in any case, 3 and 4 maybe if there is a tool which allows to scan through it efficiently and point 5 I wrote here just for information.
Help wanted
Help is wanted primarily so that someone could maybe point me to the best tool to find and browse through those changesets (find changesets by
created_by
with a certain changesetcomment
) efficiently, and maybe even fix those in place without using another editor? Or maybe there is an even more efficient way to do this.The text was updated successfully, but these errors were encountered: