Wrong message for quests disabled in some countries ?

[PanierAvide]

It seems that now, StreetComplete implements a sort of filter for quests by countries, which is a good idea. But when I first saw this :

I was like : why do they disabled these quests in France ?? ("Ne jamais afficher en France" = "Do not display in France"). Looking up at the source code led me to the conclusion that in fact it's the contrary which is done : these quests are enabled only in a few countries, including France.

So, there is an issue somewhere : whether the label is not correctly translated (maybe should be instead "Available in France"), or the condition to make it show up/hide is wrong (should not appear on these quests). As I'm not sure which should be corrected, I'm opening this issue.

Regards.

[ENT8R]

whether the label is not correctly translated (maybe should be instead "Available in France")

That a quest is available in a country is the default case, so this is not displayed at all.

[rugk]

these quests are enabled only in a few countries, including France.

I can confirm it. From the quest list you have the "disabled in … countries" link, which takes you to the map, and you'll see that tactile pavings are enabled for France.

Also I see a little display error: If they were actually disabled, it should display them greyed out and without a checkmark, so they cannot be enabled by a user.

[matkoniecz]

so they cannot be enabled by a user

Why? Disable quests are not disabled because are actively harmful but because added data is usually nearly useless. But users may want (because they live in a unique place or because they have different priorities or maybe because situation changed and quest is now useful)

[matkoniecz]

whether the label is not correctly translated

Can you look at https://github.com/westnordost/StreetComplete/blob/master/CONTRIBUTING.md#translating-the-app and check translation? I am unable to check translation into French.

[PanierAvide]

The translation is right according to english "never shown in XXX" is correctly translated in french by "ne jamais afficher en XXX". As the translation seems right, the bug is elsewhere.

[matkoniecz]

Can you switch language of your Android to English and upload screenshot with app in English? (and switch later back to your language)

I am still not 100% sure what is the problem.

[PanierAvide]

I'm pretty sure the error comes from this method, as the rest seems good :
https://github.com/westnordost/StreetComplete/blob/ea49f25bfe1b16d57674861b76137fde2c1a98b7/app/src/main/java/de/westnordost/streetcomplete/settings/QuestSelectionAdapter.java#L197
I will send you the screenshot in English ASAP.

[PanierAvide]

[westnordost]

Looks like a bug

[westnordost]

So, do bus stop quests pop up in France? (Is this only a display bug in this view?)

[PanierAvide]

Yes, I can retrieve tactile_paving on bus stop quest in France, it's still working.

[westnordost]

Okay, so the issue is that the country code for France is FX

[westnordost]

Fixed. I think there was also a crash bug: If you scroll into the middle of the ocean and then open the quest list (and scroll down to one quest that is not enabled everywhere), it used to crash I think. Replaced the crash with an easter egg ;-)

[rugk]

Replaced the crash with an easter egg ;-)

😍

[rugk]

Okay, so the issue is that the country code for France is FX

Ugh, no…?
Or who does say so? DDG quotes ISO 3166.

Edit: Actually that seems to be an outdated code for "France metropolitan"…

[westnordost]

Hmm well, FX is used in the country boundaries file in JOSM, StreetComplete just uses this file as well.

Edit: FR is also used, by the way, so it is not a mistake.