Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request confirmation before resetting quest selection configuration #1095

Closed
waldyrious opened this issue Jun 6, 2018 · 4 comments
Closed

Comments

@waldyrious
Copy link
Contributor

I just clicked "Reset" in the quest selection view, by mistake, and all the customizations I had done were instantly gone. Of course this is my own fault, but since this is a destructive action, it would be nice to get a confirmation dialog, to prevent such errors.

To make it extra nice, perhaps the app could also show a "toast" message confirming the deed, and offering a last chance to undo it (I believe toast messages can have an active button attached to them — at least I've seen that UI in another app)

@rugk
Copy link
Contributor

rugk commented Jun 6, 2018

With "reset" button you mean your phone's (hard- or soft-) back-button when you have a quest open?

@westnordost
Copy link
Member

westnordost commented Jun 6, 2018

Yeah, these kind of "toasts" are called "snackbars"... Android naming 🙄

To do this (show a confirmation dialog) makes sense.

@westnordost
Copy link
Member

Ah, this is done

@waldyrious
Copy link
Contributor Author

waldyrious commented Jun 20, 2018

With "reset" button you mean your phone's (hard- or soft-) back-button when you have a quest open?

Sorry I didn't reply earlier. I meant the "reset" link that shows up within the app, in the top right of the "Quest selection" section of the settings.

Ah, this is done

Thank you! For future reference, the relevant commit was 7d6f102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants