Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Quest: farm shops and food vending machines #1042

Closed
5 tasks done
stefangrotz opened this issue Apr 30, 2018 · 6 comments
Closed
5 tasks done

New Quest: farm shops and food vending machines #1042

stefangrotz opened this issue Apr 30, 2018 · 6 comments

Comments

@stefangrotz
Copy link

stefangrotz commented Apr 30, 2018

General

Affected tag(s) to be modified/added:

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by everyone from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of elements have the same answer (No spam)
  • 🕓 Applies to a reasonable number of elements (Worth the effort)

Ideas for implementation

Start with basic information and go into detail laiter

Element selection:

[out:json][timeout:25];
  // gather results
  (
  // query part for: “vending=milk”
  node["vending"="milk"]({{bbox}});
  way["vending"="milk"]({{bbox}});
  relation["vending"="milk"]({{bbox}});
  // query part for: “shop=farm”
  node["shop"="farm"]({{bbox}});
  way["shop"="farm"]({{bbox}});
  relation["shop"="farm"]({{bbox}});
  // query part for: “vending=food”
  node["vending"="food"]({{bbox}});
  way["vending"="food"]({{bbox}});
  relation["vending"="food"]({{bbox}});
  );
  // print results
  out body;
  >;
  out skel qt;

Metadata needed:

Proposed GUI:
Proposal will be added later.

I will add aditional information on this issue later.

Disclaimer: I use all the tags above for my project that shows farm shops around my city:
https://codeforkarlsruhe.github.io/direktvermarkter/

Best wishes,
Stefan

@rugk
Copy link
Contributor

rugk commented Apr 30, 2018

"Affected tag(s) to be modified/added:" is for the tags you want to add/change when the quest is solved, not the one where you specify what to select(as you specify that in "Element selection").
Also you did not say what your quest is actually supposed to ask, so I don't know at all what this quest is actually about.

@ENT8R
Copy link
Contributor

ENT8R commented Apr 30, 2018

Affected tag(s) to be modified/added:

  • shop=farm
  • amenity=vending_machine
    ** vending=milk
    ** vending=food
  • name
  • opening_hours
  • addr
  • website

For the name quest see #309; shop=farm is already included in the opening hours quest; for the website see #454; the addr:*=* tag should be set independent of whether this element is a shop or a house (BTW: there is even already a quest which asks for the house number and another quest for adding the street name is planned in #213

Also you did not say what your quest is actually supposed to ask, so I don't know at all what this quest is actually about.

I think it should ask whether a shop tagged as shop=farm has a vending machine for selling e.g. milk or other food. @stefangrotz Is that right?

@stefangrotz did you really read the quest suggestion checklist? I doubt that there are many farm shops with an own vending machine so

Not an overwhelming percentage of elements have the same answer (No spam)

and

🕓 Applies to a reasonable number of elements (Worth the effort)

would be wrong...

And what should be tagged if there is not such a vending machine? There has to be always an equivalent tagging scheme in OSM:

🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)

I will add additional information on this issue later.

Why not doing it directly if you open a new issue? This way we maybe know directly what you are talking about 😄

@stefangrotz
Copy link
Author

Hey,

Also you did not say what your quest is actually supposed to ask, so I don't know at all what this quest is actually about.

You are right, I didn't think this trough enough.

@stefangrotz did you really read the quest suggestion checklist? I doubt that there are many farm shops with an own vending machine

At least in my regions there a quite a few farms with milk and egg vending machines. When you look at this map from Karlsruhe, the blue markers are vending machines and the green ones are regular farm shops:
https://codeforkarlsruhe.github.io/direktvermarkter/

For the name quest see #309; shop=farm is already included in the opening hours quest; for the website see #454; the addr:= tag should be set independent of whether this element is a shop or a house (BTW: there is even already a quest which asks for the house number and another quest for adding the street name is planned in #213

I get your point. Do you think that it would be better to have a seperate quest for vending machines in general and keep farm shops out of this?

Why not doing it directly if you open a new issue?

I don't have much time right now but I wanted to use the time I have to start working on this. I didn't expect you guys to react so quickly :) I thought I could finish writing this issue in the evening.

@ENT8R
Copy link
Contributor

ENT8R commented Apr 30, 2018

I get your point. Do you think that it would be better to have a seperate quest for vending machines in general and keep farm shops out of this?

But I don't really get yours 😄... What should be the question which is asked to the user? And what should be set if the answer is yes and what if the answer is no?

@rugk
Copy link
Contributor

rugk commented Apr 30, 2018

Whatever the actual question asked is, it may be better when @stefangrotz thinks this over another time, maybe splits it into multiple quests and actually fills out the issue template. There is still so much confusion about what this should ask.

Also remember to read-through the quest guidelines. There, e.g.one important guideline is the atomic quest one:

⚛️ Atomic quests: Per quest, only one thing should need to be answered by the user.

So don't tag thousand things per quest, but one thing, and ask one question.

@stefangrotz
Copy link
Author

You are right. I will start over in the evening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants