-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Quest: farm shops and food vending machines #1042
Comments
"Affected tag(s) to be modified/added:" is for the tags you want to add/change when the quest is solved, not the one where you specify what to select(as you specify that in "Element selection"). |
For the name quest see #309;
I think it should ask whether a shop tagged as @stefangrotz did you really read the quest suggestion checklist? I doubt that there are many farm shops with an own vending machine so
and
would be wrong... And what should be tagged if there is not such a vending machine? There has to be always an equivalent tagging scheme in OSM:
Why not doing it directly if you open a new issue? This way we maybe know directly what you are talking about 😄 |
Hey,
You are right, I didn't think this trough enough.
At least in my regions there a quite a few farms with milk and egg vending machines. When you look at this map from Karlsruhe, the blue markers are vending machines and the green ones are regular farm shops:
I get your point. Do you think that it would be better to have a seperate quest for vending machines in general and keep farm shops out of this?
I don't have much time right now but I wanted to use the time I have to start working on this. I didn't expect you guys to react so quickly :) I thought I could finish writing this issue in the evening. |
But I don't really get yours 😄... What should be the question which is asked to the user? And what should be set if the answer is yes and what if the answer is no? |
Whatever the actual question asked is, it may be better when @stefangrotz thinks this over another time, maybe splits it into multiple quests and actually fills out the issue template. There is still so much confusion about what this should ask. Also remember to read-through the quest guidelines. There, e.g.one important guideline is the atomic quest one:
So don't tag thousand things per quest, but one thing, and ask one question. |
You are right. I will start over in the evening :) |
General
Affected tag(s) to be modified/added:
** vending=milk
** vending=food
Checklist
Checklist for quest suggestions (see guidelines):
Ideas for implementation
Start with basic information and go into detail laiter
Element selection:
Metadata needed:
Proposed GUI:
Proposal will be added later.
I will add aditional information on this issue later.
Disclaimer: I use all the tags above for my project that shows farm shops around my city:
https://codeforkarlsruhe.github.io/direktvermarkter/
Best wishes,
Stefan
The text was updated successfully, but these errors were encountered: