Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with starlite websockets test #2702

Closed
kristjanvalur opened this issue Apr 9, 2023 · 1 comment
Closed

Issue with starlite websockets test #2702

kristjanvalur opened this issue Apr 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kristjanvalur
Copy link
Contributor

kristjanvalur commented Apr 9, 2023

Just a heads up, there is an issue with the Starlite websockets test client which causes unittests to sometimes hang.
This is some issue with starlite itself, because the websocket_connect() method deadlocks if it raises a WebsocketDisconnect.

I'm working on a PR to disable the test in question, and to fix some race conditions regartig websocket connect timeouts.

Describe the Bug

System Information

  • Operating system:
  • Strawberry version (if applicable):

Additional Context

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@kristjanvalur
Copy link
Contributor Author

I guess this is closed with the merging of 2703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant