Duplicate and misplaced logic in roles crates

[rrybarczyk]

Background

When reviewing @plebhash #813, I found a lot of general and/or duplicate logic within each role's crate.

• Issue Common cross-protocol utilities are bound to sv2-specific crates #972 is related in expressing the need for the movement of logic in non-roles crates to the universal common crate (which is being severely under utilized). This issue identifies logic within the roles crates that should be moved/aggregated.
• Issue JDC is not logging any error on wrong TP configuration #863 points out that the JDC config toml can contain errors that are not immediately caught. This error checking should be handled in common logic using custom deserialization implementation.
• Issue Move JDC initialization from main to lib #992 points out that DC initialization is happening inside main.rs rather than lib.rs which makes it not very modular.

Problem

This logic is misplaced (does not make sense to belong to a specific role), and there is a lot of duplicate logic that can lead to bugs.

For example:

• fn duration_from_toml is repeated in jd-server::lib::mod and jd-client::lib::proxy_config.
• CoinbaseOutput is repeated in jd-server::lib::mod, jd-client::lib::proxy_config, and pool::lib::mining_pool::mod. This is only needed because the roles_logic_sv2::CoinbaseOutput does not derive serde::Deserialize which is needed when using the toml crate to read and parse the config tomls.
• fn get_coinbase_output is repeated in jd-server::lib::mod, jd-client::lib::proxy_config, and pool::lib::mining_pool::mod. It is used to read and parse the coinbase_outputs from the role's config tomls.
• Duplicate Args logic in translator::args and jd-client::args

Solution

Identify all the duplicate and common logic within the roles crates and begin moving them into the common crate.

Proper Handling of CoinbaseOutput

Regarding the duplicate CoinbaseOutput, this logic can be completely removed if a custom deserialization on Config is added like:

#[derive(Debug, Deserialize, Clone)]
pub struct ProxyConfig {
    //
    // Other ProxyConfig fields
    //
    #[serde(deserialize_with = "deser_coinbase_output")]
    pub coinbase_outputs: Vec<CoinbaseOutput>,
    //
    // Other ProxyConfig fields
    //
}

fn deser_coinbase_output<'de, D>(deserializer: D) -> Result<Vec<CoinbaseOutput>, D::Error>
where
    D: serde::Deserializer<'de>,
{
    todo!()
}

In order to make the get_coinbase_output method working, the following implementation should be added to protocols::v2::roles_logic_sv2::utils:

impl TryFrom<&CoinbaseOutput> for Script {
    type Error = Error;

    fn try_from(value: &CoinbaseOutput) -> Result<Self, Self::Error> {
        // Same implementation as the existing `impl TryFrom<CoinbaseOutput> for Script` in this file
    }
}

Then all duplicate CoinbaseOutput structs in the roles crates can be removed.