Implement a Termination Protection safeguard #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2022
# [2.1.0](v2.0.1...v2.1.0) (2022-10-15) ### Features * **termination protection check:** Implement a Termination Protection safeguard ([#125](#125)) ([b9dfafd](b9dfafd))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This changeset makes it so the utility will check if any stages that would be destroyed have termination protection enabled; if any do, it will refuse to continue.
Linked Issues to Close
Closes #3
Approach
The way the logic flows in the utility, there was the distinct possibility that termination protection enabled stages would have their S3 buckets emptied prior to the utility failing.
These changes avoid that. Up front, before confirmation is even requested, the utility will check each would-be-destroyed cloudformation stack for termination protection. If any have termination protection enabled, the utility will refuse to continue the destruction process any further, leaving the stacks untouched. This is a safer way to do things.
Learning
N/A
Assorted Notes/Considerations
Feat / Enhancement
Pull Request Creator Checklist
Pull Request Assignee Checklist