-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static_assert
failure when used with fmt 9.0.0+
#366
Comments
Same issue. |
yeah, fmt 9.0.0 seems broken. fmtlib/fmt#2936 I suggest to revert to 8.1.1 or try HEAD of master: https://github.com/fmtlib/fmt/ |
From the 9.0.0 release notes, this item seem like it might be the cause for the error. It sounds like that won't go away with future fmt versions, so at some point Sophus should adapt to it (ideally while staying compatible to older versions of fmt).
To test one could define |
For future reference, this was fixed in #376. (At the very least, this is fixed in the latest version of Sophus.) |
Describe the bug
Using Sophus with fmt 9.0.0+ produces the following error:
To Reproduce
Install fmt 9.0.0, and then try to use Sophus. For example, the following makes use of
HelloSO3.cpp
:Running the above
CMakeLists.txt
withHelloSO3.cpp
in your current working directory withcmake . && make
produces the error shown above.Expected behavior
No error.
Sophus version: 4ac843d
I haven't found time to test on
HEAD
yet, but the changes to the files in the call stack since this commit hash don't look to have fixed the issue.Additional context
So far I've reproduced this on macOS 11 with Apple-provided Clang, but I don't think this is specific to that.
The text was updated successfully, but these errors were encountered: