Don't update the state of the form if WYSIWYG content has not changed #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauriejim
added
pr: 🐛 Bug fix
source: core:content-manager
|
Thanks @johanbaath I didn't cover this use case! |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR is a:
🐛 Bug fix
Main update on the:
Admin
Description
Since the first field is autofocused
(key === 0), this causes a problem with WYSIWYG fields emitting anonChangeevent.When the edit page loads, the first field is focused even before data has loaded. So when this field is a WYSIWYG, it will change the value to a blank string. Saving the form without touching the first field makes it a blank string effectively wiping it from the database.